From: Vladimir Zapolskiy <vz@mleia.com>
To: Gao Pan <pandy.gao@nxp.com>,
wsa@the-dreams.de, wsa-dev@sang-engineering.com
Cc: linux-i2c@vger.kernel.org, frank.li@nxp.com
Subject: Re: [Patch V3] i2c: imx-lpi2c: add VLLS mode support
Date: Tue, 17 Jan 2017 23:04:50 +0200 [thread overview]
Message-ID: <008db20d-9353-4af5-b97c-fa3550f31e20@mleia.com> (raw)
In-Reply-To: <1484648455-5454-1-git-send-email-pandy.gao@nxp.com>
On 01/17/2017 12:20 PM, Gao Pan wrote:
> When system enters VLLS mode, module power is turned off. As a result,
> all registers are reset to HW default value. After exiting VLLS mode,
> registers are still in default mode. As a result, the pinctrl settings
> are incorrect, which will affect the module function.
>
> The patch recovers the pinctrl setting when exit VLLS mode.
>
> Signed-off-by: Gao Pan <pandy.gao@nxp.com>
> ---
> V2:
> -drop "#else branch" and IMX_LPI2C_PM completely
> -pm = &imx_lpi2c_pm
>
> V3:
> -remove unnecessary #ifdef
>
The change looks good, thank you for updates.
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2017-01-17 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 10:20 [Patch V3] i2c: imx-lpi2c: add VLLS mode support Gao Pan
2017-01-17 21:04 ` Vladimir Zapolskiy [this message]
2017-01-25 20:53 ` Wolfram Sang
2017-01-25 21:10 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=008db20d-9353-4af5-b97c-fa3550f31e20@mleia.com \
--to=vz@mleia.com \
--cc=frank.li@nxp.com \
--cc=linux-i2c@vger.kernel.org \
--cc=pandy.gao@nxp.com \
--cc=wsa-dev@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).