From: Ray Jui <ray.jui@broadcom.com>
To: Wolfram Sang <wsa@the-dreams.de>, Ray Jui <rjui@broadcom.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Icarus Chau <ichau@broadcom.com>
Subject: Re: [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case
Date: Fri, 12 Feb 2016 11:32:53 -0800 [thread overview]
Message-ID: <00a4c0fe-962c-3e76-fb53-1c5eadb95af9@broadcom.com> (raw)
In-Reply-To: <20160212193119.GR1520@katana>
On 2/12/2016 11:31 AM, Wolfram Sang wrote:
>> +static int bcm_iproc_i2c_init(struct bcm_iproc_i2c_dev *iproc_i2c);
>> +static void bcm_iproc_i2c_enable_disable(struct bcm_iproc_i2c_dev *iproc_i2c,
>> + bool enable);
>
> Can't we move these functions instead of having the extra declarations?
>
I had the same opinion during our internal review, :)
I'll do that in the next revision of this patch set.
Thanks,
Ray
next prev parent reply other threads:[~2016-02-12 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 0:27 [PATCH 0/3] iProc I2C driver enhancement Ray Jui
2016-01-28 0:27 ` [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case Ray Jui
2016-02-12 19:31 ` Wolfram Sang
2016-02-12 19:32 ` Ray Jui [this message]
2016-01-28 0:27 ` [PATCH 2/3] i2c: iproc: Fix typo in the driver Ray Jui
2016-01-28 0:27 ` [PATCH 3/3] i2c: iproc: Support larger TX transfer Ray Jui
2016-02-12 19:33 ` Wolfram Sang
2016-02-12 19:33 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00a4c0fe-962c-3e76-fb53-1c5eadb95af9@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ichau@broadcom.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).