From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440. Date: Wed, 21 Jul 2010 22:55:20 +0900 Message-ID: <00a901cb28dc$75b5dc80$61219580$%kim@samsung.com> References: <1279717167-24456-1-git-send-email-kgene.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: Content-language: ko Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Kyungmin Park' Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, 'Naveen Krishna Ch' List-Id: linux-i2c@vger.kernel.org Kyungmin Park wrote: >=20 > I don't want to modify Kconfig anymore. it's simple to modify driver itself. >=20 Yeah, I think so. > Think the usage of I2c. I think there's no case don't use it. >=20 > At this time modify Kconfig once, and just fix the driver if new SoCs > are arrives. > Of course we can modify Kconfig one more, If there's really new IPs o= f > I2C are created. but I expect we also need to define new PLAT_SAMSUNG= 2 >=20 Maybe you did see the Watchdog driver...I think, in this case, the depe= nding on 'HAVE_xxx_I2C' is better than 'PLAT_xxx'. If there is newer I2C, the 'HAVE_xxx_I2Cv2' is enough. > Thank you, > Kyungmin Park >=20 > On Wed, Jul 21, 2010 at 9:59 PM, Kukjin Kim w= rote: > > From: Naveen Krishna Ch > > > > This patch is to select support I2C channels 0, 1 and 2 for S5PV210= and > S5P6440. > > > > Signed-off-by: Naveen Krishna Ch > > Signed-off-by: Kukjin Kim > > --- > > Changes since v1: > > - Modifed the Kconfig help comments. > > > > =A0drivers/i2c/busses/Kconfig | =A0 =A06 +++--- > > =A01 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfi= g > > index bceafbf..27c96ec 100644 > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -523,10 +523,10 @@ config I2C_PXA_SLAVE > > > > =A0config I2C_S3C2410 > > =A0 =A0 =A0 =A0tristate "S3C2410 I2C Driver" > > - =A0 =A0 =A0 depends on ARCH_S3C2410 || ARCH_S3C64XX > > + =A0 =A0 =A0 depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P64= 40 || > ARCH_S5PV210 > > =A0 =A0 =A0 =A0help > > - =A0 =A0 =A0 =A0 Say Y here to include support for I2C controller = in the > > - =A0 =A0 =A0 =A0 Samsung S3C2410 based System-on-Chip devices. > > + =A0 =A0 =A0 =A0 Say Y here to include support for I2C controller = in the Samsung > > + =A0 =A0 =A0 =A0 S3C2410, S3C64XX, S5P6440 and S5PV210 based Syste= m-on-Chip > devices. > > > > =A0config I2C_S6000 > > =A0 =A0 =A0 =A0tristate "S6000 I2C support" > > -- > > 1.6.2.5 > > > > -- Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.