Re: [PATCH 1/2] dt-bindings: i2c: designware: allow fine tuning tuning waveform from device tree

Krzysztof Kozlowski
2024-02-01T07:33:52Z

On 01/02/2024 05:46, Aahil Awatramani wrote:
> The Synopsys i2c driver allows a user to override the parameters

Driver? That already suggests it is not suitable for binding...

> controlling the waveform using ACPI; this is useful for fine tuning when
> needed to make spec compliance. Extend this support to the device tree to
> allow non-ACPI platforms the same capabilities.
>
> Signed-off-by: Aahil Awatramani <aahila@google.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt
> index fc3dd7ec0445..3c33c36571f9 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c.txt
> @@ -45,6 +45,24 @@ wants to support one of the below features, it should adapt these bindings.
> Number of nanoseconds the SCL signal takes to rise; t(r) in the I2C
> specification.
>
> +- i2c-scl-ss-hcnt
> + HCNT value for standard speed mode in I2C Controller.

I have no clue what is HCNT, so I expect you to help us understand what
is this and why this is suitable for DT. Your reference to driver
suggests it is not suitable for DT.

Best regards,
Krzysztof