Re: [PATCH net-next v8 8/9] net: txgbe: Implement phylink pcs

Lars-Peter Clausen
2023-05-16T02:46:35Z

On 5/14/23 23:31, Jiawen Wu wrote:
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h
> index 6c903e4517c7..6c0393c19b83 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_type.h
> @@ -80,6 +80,10 @@
> /* I2C registers */
> #define TXGBE_I2C_BASE 0x14900
>
> +/************************************** ETH PHY ******************************/
> +#define TXGBE_XPCS_IDA_ADDR 0x13000
> +#define TXGBE_XPCS_IDA_DATA 0x13004
> +
> /* Part Number String Length */
> #define TXGBE_PBANUM_LENGTH 32
>
> @@ -171,6 +175,8 @@ struct txgbe_nodes {
> struct txgbe {
> struct wx *wx;
> struct txgbe_nodes nodes;
> + struct mdio_device *mdiodev;

While assigned mdiodev is never read.

> + struct dw_xpcs *xpcs;
> struct platform_device *sfp_dev;
> struct platform_device *i2c_dev;
> struct clk_lookup *clock;