Re: [PATCH v4] i2c: add support for Zhaoxin I2C controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/06/2023 14:24, Andi Shyti wrote:
>> +
>> +static int zxi2c_probe(struct platform_device *pdev)
>> +{
>> +	int err = 0;
>> +	struct zxi2c *i2c;
>> +	struct pci_dev *pci;
>> +	struct device *dev;
>> +
>> +	/* make sure this is zhaoxin platform */
> 
> Krzysztof is asking what does this mean? I guess here you are
> checking if the device connected is really the zhaixin plaform of
> this driver. Makes sense. Just to avoid misunderstandings we
> could rephrase this with something like:
> 
> 	/*
> 	 * Check if vendor and device ID match the expected
> 	 * values for the zhaoxin platform
> 	 */
> 
> would it work?

I don't understand why does it make sense. Only correct devices are
matched, right? So either this is impossible condition or  this is
plugged into other proper platform. In both cases you should not have
such checks.

Why would ever a driver check in probe what platform it is?

Best regards,
Krzysztof