* [PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440
@ 2013-01-19 5:12 Kukjin Kim
2013-01-19 10:52 ` Tomasz Figa
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2013-01-19 5:12 UTC (permalink / raw)
To: linux-samsung-soc, linux-i2c; +Cc: Wolfram Sang, Giridhar Maruthy, Kukjin Kim
From: Giridhar Maruthy <giridhar.m@samsung.com>
Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index a290d08..ec141b4 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -109,6 +109,8 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_driver_ids);
static const struct of_device_id s3c24xx_i2c_match[] = {
{ .compatible = "samsung,s3c2410-i2c", .data = (void *)0 },
{ .compatible = "samsung,s3c2440-i2c", .data = (void *)QUIRK_S3C2440 },
+ { .compatible = "samsung,exynos5440-i2c",
+ .data = (void *)(QUIRK_S3C2440 | QUIRK_NO_GPIO) },
{ .compatible = "samsung,s3c2440-hdmiphy-i2c",
.data = (void *)(QUIRK_S3C2440 | QUIRK_HDMIPHY | QUIRK_NO_GPIO) },
{},
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440
2013-01-19 5:12 [PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440 Kukjin Kim
@ 2013-01-19 10:52 ` Tomasz Figa
2013-01-20 23:28 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Figa @ 2013-01-19 10:52 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc, linux-i2c, Wolfram Sang, Giridhar Maruthy
Hi Kukjin,
You should also add the new compatible value to the documentation of
device tree bindings for i2c-s3c2410.
(Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt)
Best regards,
Tomasz Figa
On Friday 18 of January 2013 21:12:03 Kukjin Kim wrote:
> From: Giridhar Maruthy <giridhar.m@samsung.com>
>
> Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c
> b/drivers/i2c/busses/i2c-s3c2410.c index a290d08..ec141b4 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -109,6 +109,8 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_driver_ids);
> static const struct of_device_id s3c24xx_i2c_match[] = {
> { .compatible = "samsung,s3c2410-i2c", .data = (void *)0 },
> { .compatible = "samsung,s3c2440-i2c", .data = (void *)QUIRK_S3C2440
> }, + { .compatible = "samsung,exynos5440-i2c",
> + .data = (void *)(QUIRK_S3C2440 | QUIRK_NO_GPIO) },
> { .compatible = "samsung,s3c2440-hdmiphy-i2c",
> .data = (void *)(QUIRK_S3C2440 | QUIRK_HDMIPHY | QUIRK_NO_GPIO) },
> {},
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440
2013-01-19 10:52 ` Tomasz Figa
@ 2013-01-20 23:28 ` Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2013-01-20 23:28 UTC (permalink / raw)
To: 'Tomasz Figa'
Cc: linux-samsung-soc, linux-i2c, 'Wolfram Sang',
'Giridhar Maruthy'
Tomasz Figa wrote:
>
> Hi Kukjin,
>
Hi,
> You should also add the new compatible value to the documentation of
> device tree bindings for i2c-s3c2410.
>
Yeah, agreed.
> (Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt)
>
Giridhar, please address comments from Tomasz.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-20 23:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-19 5:12 [PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440 Kukjin Kim
2013-01-19 10:52 ` Tomasz Figa
2013-01-20 23:28 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).