From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F32DBC7EE23 for ; Tue, 30 May 2023 08:41:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbjE3Ilo (ORCPT ); Tue, 30 May 2023 04:41:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230393AbjE3Ilg (ORCPT ); Tue, 30 May 2023 04:41:36 -0400 Received: from smtpbguseast1.qq.com (smtpbguseast1.qq.com [54.204.34.129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E793BA1; Tue, 30 May 2023 01:41:30 -0700 (PDT) X-QQ-mid: Yeas49t1685436037t569t54720 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [183.159.96.128]) X-QQ-SSF: 00400000000000F0FOF000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 9616780576815440517 To: "'Russell King \(Oracle\)'" , "'kernel test robot'" Cc: , , , , , , , , , , , , "'Piotr Raczynski'" References: <20230524091722.522118-6-jiawenwu@trustnetic.com> <202305261959.mnGUW17n-lkp@intel.com> <02dd01d991d2$2120fcf0$6362f6d0$@trustnetic.com> In-Reply-To: <02dd01d991d2$2120fcf0$6362f6d0$@trustnetic.com> Subject: RE: [PATCH net-next v9 5/9] net: txgbe: Add SFP module identify Date: Tue, 30 May 2023 16:40:36 +0800 Message-ID: <03ac01d992d2$67c1ec90$3745c5b0$@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFlCTXCD0V13/nxYaH3lJLB+zCPMgFguorBARt7XSgCWWopnLA04bqA Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Monday, May 29, 2023 10:06 AM, Jiawen Wu wrote: > On Friday, May 26, 2023 7:37 PM, Russell King (Oracle) wrote: > > On Fri, May 26, 2023 at 07:30:45PM +0800, kernel test robot wrote: > > > Kconfig warnings: (for reference only) > > > WARNING: unmet direct dependencies detected for I2C_DESIGNWARE_PLATFORM > > > Depends on [n]: I2C [=n] && HAS_IOMEM [=y] && (ACPI && COMMON_CLK [=y] || !ACPI) > > > Selected by [y]: > > > - TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] > > > WARNING: unmet direct dependencies detected for SFP > > > Depends on [n]: NETDEVICES [=y] && PHYLIB [=y] && I2C [=n] && PHYLINK [=y] && (HWMON [=n] || HWMON [=n]=n) > > > Selected by [y]: > > > - TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] > > > > ... and is basically caused by "select SFP". No. Do not do this unless > > you look at the dependencies for SFP and ensure that those are also > > satisfied - because if you don't you create messes like the above > > build errors. > > So how do I make sure that the module I need compiles and loads correctly, > rely on the user to manually select it? When I changed the TXGBE config to: ... depends on SFP select PCS_XPCS ... the compilation gave an error: drivers/net/phy/Kconfig:16:error: recursive dependency detected! drivers/net/phy/Kconfig:16: symbol PHYLIB is selected by PHYLINK drivers/net/phy/Kconfig:6: symbol PHYLINK is selected by PCS_XPCS drivers/net/pcs/Kconfig:8: symbol PCS_XPCS is selected by TXGBE drivers/net/ethernet/wangxun/Kconfig:40: symbol TXGBE depends on SFP drivers/net/phy/Kconfig:63: symbol SFP depends on PHYLIB For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations" Seems deleting "depends on SFP" is the correct way. But is this normal? How do we ensure the dependency between TXGBE and SFP?