linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Fiergolski <Adrian.Fiergolski@cern.ch>
To: Peter Rosin <peda@axentia.se>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] check I2C device id for pca984x chips
Date: Fri, 26 Jan 2018 17:33:29 +0100	[thread overview]
Message-ID: <04535e9d-9ba4-2f27-e94c-12d877d26cda@cern.ch> (raw)
In-Reply-To: <20180122113657.32094-1-peda@axentia.se>

Hi Peter,

Sorry for the late reply.

Yes, it's true I have one of the chip. However, my yocto based build system
depends on https://github.com/Xilinx/linux-xlnx and it's in version
4.9.0-xilinx-v2017.3.
Apparently, there were some bigger changes in i2c core between this
version and
upstream, thus your patches don't apply.

Next week I will try to align only me i2c subdirectory with upstream.
Provided it compiles, I will
try then to apply and confirm your patches.

Regards,
Adrian

On 22.01.2018 at 12:36, Peter Rosin wrote:
> Hi!
>
> This series tries to check the I2C device id, but instead of open
> coding the check in the pca954x driver, I have a new function in
> the core doing the work.
>
> The code is only compile-tested, hence the RFC, and I would really
> like a Tested-by: tag from Adrian who presumably have one of these
> chips.
>
> Also, I'm not sure if I should list all manufacturers that I know
> about in the header, or if I should settle for the one that is
> actually used and leave the others to be added by whomever needs
> them...
>
> Cheers,
> peda
>
> Peter Rosin (2):
>   i2c: add i2c_get_device_id() to get the standard i2c device id
>   i2c: mux: pca954x: verify the device id of the pca984x chips
>
>  drivers/i2c/i2c-core-base.c         | 33 ++++++++++++++++++++++++++++
>  drivers/i2c/muxes/i2c-mux-pca954x.c | 43 +++++++++++++++++++++++++++++++++++++
>  include/linux/i2c.h                 | 30 ++++++++++++++++++++++++++
>  3 files changed, 106 insertions(+)
>

  parent reply	other threads:[~2018-01-26 16:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 11:36 [RFC PATCH 0/2] check I2C device id for pca984x chips Peter Rosin
2018-01-22 11:36 ` [RFC PATCH 1/2] i2c: add i2c_get_device_id() to get the standard i2c device id Peter Rosin
2018-03-04 21:47   ` Peter Rosin
2018-03-05 15:51   ` Wolfram Sang
2018-03-05 16:06     ` Peter Rosin
2018-03-05 16:27       ` Wolfram Sang
2018-01-22 11:36 ` [RFC PATCH 2/2] i2c: mux: pca954x: verify the device id of the pca984x chips Peter Rosin
2018-03-05 15:53   ` Wolfram Sang
2018-03-05 15:55     ` Peter Rosin
2018-03-05 16:29       ` Wolfram Sang
2018-01-26 16:33 ` Adrian Fiergolski [this message]
2018-01-27  8:37   ` [RFC PATCH 0/2] check I2C device id for " Peter Rosin
2018-01-29 17:38     ` Adrian Fiergolski
2018-02-01 14:41       ` Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04535e9d-9ba4-2f27-e94c-12d877d26cda@cern.ch \
    --to=adrian.fiergolski@cern.ch \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).