From: Florian Fainelli <f.fainelli@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>, Ray Jui <ray.jui@broadcom.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 0/9] iProc I2C slave mode and NIC mode
Date: Wed, 3 Apr 2019 15:20:14 -0700 [thread overview]
Message-ID: <06dff712-151b-f188-d154-3130d56d01d8@gmail.com> (raw)
In-Reply-To: <20190403204423.btgtke3tmt7pkr3j@ninjato>
On 4/3/19 1:44 PM, Wolfram Sang wrote:
> On Tue, Apr 02, 2019 at 06:18:21PM -0700, Ray Jui wrote:
>> This patch series adds the following support to the iProc I2C driver:
>> - Increase maximum read transfer size to 255 bytes
>> - I2C slave mode
>> - Polling mode
>> - NIC I2C mode
>>
>> This patch series is based on kernel v5.1-rc3 and available at:
>> https://github.com/Broadcom/arm64-linux.git
>> branch: i2c-slave-v6
>>
>> Changes from v5:
>> - Address various comments from Wolfram
>
> In the future, please write in detail what you changed. I review so many
> patches that I can't recall all my comments on every patch.
>
> That being said, all patches applied to for-next, thanks!
OK, I will drop patch #9 from my queue then, thanks.
>
> Can be fixed incrementally, my code checkers complain about:
>
> CPPCHECK
> drivers/i2c/busses/i2c-bcm-iproc.c:720:14: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
> val |= 1 << M_TX_WR_STATUS_SHIFT;
> ^
> drivers/i2c/busses/i2c-bcm-iproc.c:847:13: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
> val &= ~(1 << TIM_CFG_MODE_400_SHIFT);
> ^
> drivers/i2c/busses/i2c-bcm-iproc.c:998:13: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
> val &= ~(1 << TIM_CFG_MODE_400_SHIFT);
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Florian
next prev parent reply other threads:[~2019-04-03 22:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 1:18 [PATCH v6 0/9] iProc I2C slave mode and NIC mode Ray Jui
2019-04-03 1:18 ` [PATCH v6 1/9] i2c: iproc: Extend I2C read up to 255 bytes Ray Jui
2019-04-03 1:18 ` [PATCH v6 2/9] i2c: iproc: Add slave mode support Ray Jui
2019-04-03 1:18 ` [PATCH v6 3/9] i2c: iproc: Add support for more master error status Ray Jui
2019-04-03 1:18 ` [PATCH v6 4/9] dt-bindings: i2c: iproc: make 'interrupts' optional Ray Jui
2019-04-03 1:18 ` [PATCH v6 5/9] i2c: iproc: add polling support Ray Jui
2019-04-03 1:18 ` [PATCH v6 6/9] i2c: iproc: use wrapper for read/write access Ray Jui
2019-04-03 1:18 ` [PATCH v6 7/9] dt-bindings: i2c: iproc: add "brcm,iproc-nic-i2c" compatible string Ray Jui
2019-04-03 1:18 ` [PATCH v6 8/9] i2c: iproc: add NIC I2C support Ray Jui
2019-04-03 1:18 ` [PATCH v6 9/9] arm64: dts: Stingray: Add NIC i2c device node Ray Jui
2019-04-04 16:28 ` Florian Fainelli
2019-04-03 20:44 ` [PATCH v6 0/9] iProc I2C slave mode and NIC mode Wolfram Sang
2019-04-03 20:56 ` Ray Jui
2019-04-03 22:20 ` Florian Fainelli [this message]
2019-04-04 6:16 ` Wolfram Sang
2019-04-04 16:28 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06dff712-151b-f188-d154-3130d56d01d8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ray.jui@broadcom.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).