From: Francesco Lavra <francescolavra.fl@gmail.com>
To: tangbin <tangbin@cmss.chinamobile.com>, wsa@the-dreams.de
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c:i2c-core-of:remove redundant dev_err message
Date: Wed, 26 Feb 2020 11:58:41 +0100 [thread overview]
Message-ID: <0757d83b-203c-fe40-a8ac-665953d7d336@gmail.com> (raw)
In-Reply-To: <20200226103901.21520-1-tangbin@cmss.chinamobile.com>
On 2/26/20 11:39 AM, tangbin wrote:
> of_i2c_register_device already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
> ---
> drivers/i2c/i2c-core-of.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c
> index 6787c1f71..7b0a786d3 100644
> --- a/drivers/i2c/i2c-core-of.c
> +++ b/drivers/i2c/i2c-core-of.c
> @@ -103,9 +103,7 @@ void of_i2c_register_devices(struct i2c_adapter *adap)
>
> client = of_i2c_register_device(adap, node);
> if (IS_ERR(client)) {
> - dev_err(&adap->dev,
> - "Failed to create I2C device for %pOF\n",
> - node);
> + return PTR_ERR(client);
This looks like an unrelated (and wrong) change. Why would you alter the
semantics of of_i2c_register_devices()? Besides, this function doesn't
have a return value.
next prev parent reply other threads:[~2020-02-26 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 10:39 [PATCH] i2c:i2c-core-of:remove redundant dev_err message tangbin
2020-02-26 10:58 ` Francesco Lavra [this message]
2020-03-10 10:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0757d83b-203c-fe40-a8ac-665953d7d336@gmail.com \
--to=francescolavra.fl@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox