From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A3DC433FE for ; Thu, 23 Dec 2021 17:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349378AbhLWRAY (ORCPT ); Thu, 23 Dec 2021 12:00:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:57178 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349369AbhLWRAS (ORCPT ); Thu, 23 Dec 2021 12:00:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640278817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nvsfcMVBWJERgEqnOROoErbQ2mtiiEO1pkWlJPmYlIg=; b=GjMjpYBJtNxLEJvjRJYNisE0QOVe7+1dOqRCyFtiMZ5kz2J0ZwwTEwT3Nvs783lQktIak7 PtgTz+JkqvzCaEmb8UUDhL7UMJNelpmMcf09AilF6W/zXstwlQc5ed6Tz704+o/G+b5Bqx RVPp+4Fh/yadduQYiHuWfF2BM0RYsAI= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-H6T03wAzPnC9i5CYLBM5Rw-1; Thu, 23 Dec 2021 12:00:16 -0500 X-MC-Unique: H6T03wAzPnC9i5CYLBM5Rw-1 Received: by mail-ed1-f72.google.com with SMTP id s7-20020a056402520700b003f841380832so4945033edd.5 for ; Thu, 23 Dec 2021 09:00:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nvsfcMVBWJERgEqnOROoErbQ2mtiiEO1pkWlJPmYlIg=; b=Em3pmIKHb0DWV3F/oKjhO6VGW75+4KsAIzKGvXpU7k/30ynpI0vscSyjrKGC5u/1e8 qtjo163oesB+Hmj3jRghjQ3A+IZYzZiH7eCB38i/jBiOczM+D6U/X9HeUYbV42Lk5MJ5 zZ1vcGEJfOFC+UmFGuIciDeu0zNi3XTv4nD3MXkbKf3qokw3DGBGA7zATFxJ92mq92JE fNVNYNFu8n1MlmYYK+iWQvwXCgW5RkFlBv43YkG3W4d9DabOzOvAX9lD1YxHlIMgDxPo 6S/+F5srFU96iRy2zuJsDYBwPwnn0/Ha4htU6vMBzerB6oDXJdRFOVDUN0Vwr48e9/tA KOsA== X-Gm-Message-State: AOAM533vAMy8niI1PD0lgcTtOvNOfPxWEf0nGqSRbZPbSfN5lIGY8JmR qxyN7ajuyiK2g6xyIK1Srl+aCsIBcs0Sy+KLk2j/J9Xf9BoBEFIAdibxSr6C//KgQKBL4QvFyOc QcQAhRCWztB/eS19vgIxt X-Received: by 2002:a05:6402:d0a:: with SMTP id eb10mr2784917edb.48.1640278815475; Thu, 23 Dec 2021 09:00:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJw87UhCINhB18oUYfK4gbd/3DsjSTlRJLtf/0Dh2g1Vscsz3MP7wWjdmIMopMNKIhj0qff5DA== X-Received: by 2002:a05:6402:d0a:: with SMTP id eb10mr2784889edb.48.1640278815306; Thu, 23 Dec 2021 09:00:15 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id mp9sm1919620ejc.106.2021.12.23.09.00.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Dec 2021 09:00:14 -0800 (PST) Message-ID: <08236e18-f1ae-303c-3d2e-96f795d96c1f@redhat.com> Date: Thu, 23 Dec 2021 18:00:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v3 0/8] platform/x86: introduce p2sb_bar() helper Content-Language: en-US To: Andy Shevchenko , Wolfram Sang , Jean Delvare , Heiner Kallweit , Lee Jones , Tan Jui Nee , Bjorn Helgaas , Mika Westerberg , Kate Hsuan , Jonathan Yong , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Jean Delvare , Peter Tyser , Andy Shevchenko , Linus Walleij , Mark Gross , Henning Schild References: <20211221181526.53798-1-andriy.shevchenko@linux.intel.com> From: Hans de Goede In-Reply-To: <20211221181526.53798-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi, On 12/21/21 19:15, Andy Shevchenko wrote: > There are a few users and at least one more is coming that would > like to utilize P2SB mechanism of hiding and unhiding a device from > the PCI configuration space. > > Here is the series to deduplicate existing users and provide > a generic way for new comers. > > It also includes a patch to enable GPIO controllers on Apollo Lake > when it's used with ABL bootloader w/o ACPI support. > > The patch that bring the helper ("platform/x86/intel: Add Primary > to Sideband (P2SB) bridge support") has a commit message that > sheds a light on what the P2SB is and why this is needed. > > Please, comment on the approach and individual patches. > > The changes made in v2 do not change the main idea and the functionality > in a big scale. What we need is probably one more (RE-)test done by Henning. > I hope to have it merged to v5.17-rc1 that Siemens can develop their changes > based on this series. > > I have tested this on Apollo Lake platform (I'm able to see SPI NOR and > since we have an ACPI device for GPIO I do not see any attempts to recreate > one). > > (Since it's cross subsystem, the PDx86 seems the main one and > I think it makes sense to route it throught it with immutable > tag or branch provided for the others). The series looks good to me: Acked-by: Hans de Goede For the series. Not sure if this is really 5.17 material this late in the cycle though, but lets wait and see what Bjorn and Lee have to say (patch 8/8 still needs an ack from Lee). I'm fine with taking this upstream through the pdx86 tree, please prepare a pull-req for everyone involved with an immutable branch pushed to pdx86/platform-drivers-x86.git/ based on 5.16-rc1 (if everyone is happy with merging this for 5.17) or based on 5.17-rc1 once that is out. Regards, Hans