From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF4C7C48BE5 for ; Wed, 16 Jun 2021 18:13:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9AE2613D3 for ; Wed, 16 Jun 2021 18:13:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231667AbhFPSPq (ORCPT ); Wed, 16 Jun 2021 14:15:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36181 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231664AbhFPSPp (ORCPT ); Wed, 16 Jun 2021 14:15:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623867218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/2ZgS+GCY+zeGtNmbikEY7JDq0qDESkYvLCgyzZHxds=; b=gJj7F+4osYo9W/2PySYTDpxbEUBbvKGUKXudluqjW7zsaCycUVFLG7g8eAKmgR3h8UIO/r s/YtnB8V5gPlwBN2K387kmRtdToWx/NgTK79dfp8xFh9UYrISGcyHb3bNPNPBZn09+RX4V heRGEtF0VHKza9iQ3hggaNtl0dK/pcg= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-71-4ITK6huSPIaxkFtI7nBLIw-1; Wed, 16 Jun 2021 14:13:37 -0400 X-MC-Unique: 4ITK6huSPIaxkFtI7nBLIw-1 Received: by mail-ej1-f70.google.com with SMTP id o6-20020a1709063586b0290454e77502aeso1289460ejb.12 for ; Wed, 16 Jun 2021 11:13:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/2ZgS+GCY+zeGtNmbikEY7JDq0qDESkYvLCgyzZHxds=; b=SQkOpxAzPORYEzBND8D62DnVTSnHUXjNu6cz8/HleyQlo0tgoBYmMKCYzpHuvJJcTt BSdalU7+m42wvcmpILpUHWstaVAp1QdRlt8xWu0t+IUbEbILSGjuUX+5+/lFVWAnPG61 XIO8zeldu9m+KNUYMk2eXqa8JmWsm6jSLu4IMJjJeQ3aD71wlKoyMtKyCkdN+06ssQpY /F1XHv2I58lqCTlMTczlF3lNAe1o7o0LRjYtQQ+t3e8NT/1J1CHs/OQsF05ExJWAZTxv sNJllPBW0T0AIPrwZ3jbDzfWgq6NqOY6EqEFoZSDttu/v/fzzBiWD558Sjdmt2qIHsOL p3Pg== X-Gm-Message-State: AOAM532bpGsvw6C8hCmQm8/PxfCchSzWU064EzjGAqChk6AYOsYhWHrl dHoxWcqgiMaInHA0sw3bq9zUPUXiGqzpYRE+T4Au9IiXu6cTXv/WXDHC4j928720PfsFy3YZpQR DtIG1hZUoDWGly/STSa1/ X-Received: by 2002:a05:6402:781:: with SMTP id d1mr1297291edy.32.1623867216482; Wed, 16 Jun 2021 11:13:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9vMHLTBq5mDNxgautgv3pvtkh5NJQutUbOxh1CWqXkx9hBbr+BTgHCyzxPgjYIs3J1MTEVA== X-Received: by 2002:a05:6402:781:: with SMTP id d1mr1297274edy.32.1623867216371; Wed, 16 Jun 2021 11:13:36 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id l26sm2498581edt.40.2021.06.16.11.13.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 11:13:36 -0700 (PDT) Subject: Re: [PATCH v5 5/6] platform/x86: Add intel_skl_int3472 driver To: Andy Shevchenko Cc: Daniel Scally , "Rafael J . Wysocki" , Andy Shevchenko , Lee Jones , Maximilian Luz , Linux Kernel Mailing List , ACPI Devel Maling List , "open list:GPIO SUBSYSTEM" , linux-i2c , Platform Driver , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , Len Brown , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Wolfram Sang , Mark Gross , Robert Moore , Erik Kaneda , Laurent Pinchart , kieran.bingham@ideasonboard.com References: <20210603224007.120560-1-djrscally@gmail.com> <20210603224007.120560-6-djrscally@gmail.com> From: Hans de Goede Message-ID: <0991caf2-1b7b-c8b5-8558-03b8f0dbb604@redhat.com> Date: Wed, 16 Jun 2021 20:13:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi, On 6/16/21 8:08 PM, Andy Shevchenko wrote: > On Wed, Jun 16, 2021 at 8:58 PM Hans de Goede wrote: >> On 6/4/21 12:40 AM, Daniel Scally wrote: >>> ACPI devices with _HID INT3472 are currently matched to the tps68470 >>> driver, however this does not cover all situations in which that _HID >>> occurs. We've encountered three possibilities: >>> >>> 1. On Chrome OS devices, an ACPI device with _HID INT3472 (representing >>> a physical TPS68470 device) that requires a GPIO and OpRegion driver >>> 2. On devices designed for Windows, an ACPI device with _HID INT3472 >>> (again representing a physical TPS68470 device) which requires GPIO, >>> Clock and Regulator drivers. >>> 3. On other devices designed for Windows, an ACPI device with _HID >>> INT3472 which does **not** represent a physical TPS68470, and is instead >>> used as a dummy device to group some system GPIO lines which are meant >>> to be consumed by the sensor that is dependent on this entry. >>> >>> This commit adds a new module, registering a platform driver to deal >>> with the 3rd scenario plus an i2c driver to deal with #1 and #2, by >>> querying the CLDB buffer found against INT3472 entries to determine >>> which is most appropriate. >>> >>> Suggested-by: Laurent Pinchart >>> Signed-off-by: Daniel Scally >> >> Thank you for your patch, I've applied this patch to my review-hans >> branch: >> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans >> >> I've fixed up the missing static marking of skl_int3472_tps68470_calc_type() >> spotted by lkp@intel.com while applying the patch to my tree. > > Are you going to apply patch 6 as well? > IIRC it's acked by Lee. Ah you are right, it is Acked, but I'm not sure if that ack was for Lee being ok with it being merged through the pdx86 tree. I'll coordinate this with Lee off list. Regards, Hans