linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH Resend] i2c/designware: dw_i2c_init_driver as subsys initcall
@ 2012-02-29  6:57 Viresh Kumar
       [not found] ` <0a4676cdd7e81363eab4eb1520b0e74f50e6c5c4.1330498492.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2012-02-29  6:57 UTC (permalink / raw)
  To: khali-PUYAD+kWke1g9hUCZPvPmw, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
	w.sang-bIcnvbaLZ9MEGnE8C9+IrQ
  Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, baruch-NswTu9S1W3P6gbPvEgmw2w,
	armando.visconti-qxv4g6HH51o, shiraz.hashim-qxv4g6HH51o,
	vipin.kumar-qxv4g6HH51o, rajeev-dlh.kumar-qxv4g6HH51o,
	deepak.sikri-qxv4g6HH51o, vipulkumar.samar-qxv4g6HH51o,
	amit.virdi-qxv4g6HH51o, viresh.kumar-qxv4g6HH51o,
	pratyush.anand-qxv4g6HH51o, bhupesh.sharma-qxv4g6HH51o,
	viresh.linux-Re5JQEeQqe8AvxtiuMwx3w, bhavna.yadav-qxv4g6HH51o,
	vincenzo.frascino-qxv4g6HH51o, mirko.gardi-qxv4g6HH51o,
	salvatore.dedominicis-qxv4g6HH51o

From: Pratyush Anand <pratyush.anand-qxv4g6HH51o@public.gmane.org>

There are few drivers which are available on i2c bus but have been initialized
with subsys_initcall. Also as I2C is also a bus driver, it should be available
as early as possible.

Therefore i2c driver must s initialized with subsys initcall in this patch.

Signed-off-by: Pratyush Anand <pratyush.anand-qxv4g6HH51o@public.gmane.org>
Signed-off-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
---
This patch was sent a long time back and was never pushed. Resending it again.

 drivers/i2c/busses/i2c-designware-platdrv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 2237398..ac953c8 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -249,7 +249,7 @@ static int __init dw_i2c_init_driver(void)
 {
 	return platform_driver_probe(&dw_i2c_driver, dw_i2c_probe);
 }
-module_init(dw_i2c_init_driver);
+subsys_initcall(dw_i2c_init_driver);
 
 static void __exit dw_i2c_exit_driver(void)
 {
-- 
1.7.8.110.g4cb5d

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH Resend] i2c/designware: dw_i2c_init_driver as subsys initcall
       [not found] ` <0a4676cdd7e81363eab4eb1520b0e74f50e6c5c4.1330498492.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
@ 2012-02-29 18:57   ` Wolfram Sang
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2012-02-29 18:57 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: khali-PUYAD+kWke1g9hUCZPvPmw, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA, baruch-NswTu9S1W3P6gbPvEgmw2w,
	armando.visconti-qxv4g6HH51o, shiraz.hashim-qxv4g6HH51o,
	vipin.kumar-qxv4g6HH51o, rajeev-dlh.kumar-qxv4g6HH51o,
	deepak.sikri-qxv4g6HH51o, vipulkumar.samar-qxv4g6HH51o,
	amit.virdi-qxv4g6HH51o, pratyush.anand-qxv4g6HH51o,
	bhupesh.sharma-qxv4g6HH51o, viresh.linux-Re5JQEeQqe8AvxtiuMwx3w,
	bhavna.yadav-qxv4g6HH51o, vincenzo.frascino-qxv4g6HH51o,
	mirko.gardi-qxv4g6HH51o, salvatore.dedominicis-qxv4g6HH51o

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On Wed, Feb 29, 2012 at 12:27:46PM +0530, Viresh Kumar wrote:
> From: Pratyush Anand <pratyush.anand-qxv4g6HH51o@public.gmane.org>
> 
> There are few drivers which are available on i2c bus but have been initialized
> with subsys_initcall. Also as I2C is also a bus driver, it should be available
> as early as possible.
> 
> Therefore i2c driver must s initialized with subsys initcall in this patch.
> 
> Signed-off-by: Pratyush Anand <pratyush.anand-qxv4g6HH51o@public.gmane.org>
> Signed-off-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
> ---
> This patch was sent a long time back and was never pushed. Resending it again.

There is a dangling 's' in the commit message. Please check patches again even
on resending.

Fixed it up myself and picked the patch.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-29 18:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-29  6:57 [PATCH Resend] i2c/designware: dw_i2c_init_driver as subsys initcall Viresh Kumar
     [not found] ` <0a4676cdd7e81363eab4eb1520b0e74f50e6c5c4.1330498492.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-02-29 18:57   ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).