From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D876CC433F5 for ; Thu, 30 Dec 2021 12:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239319AbhL3MeR (ORCPT ); Thu, 30 Dec 2021 07:34:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47164 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239305AbhL3MeQ (ORCPT ); Thu, 30 Dec 2021 07:34:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640867656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ut4wgPb7k5x4/Ao0enPwI8WZ94CXIktnwuIhAN3PoC8=; b=GPtO54UiVgbK5S19Qh9s6BnQxsqHZWmO/SAUSWjprxdGpRtQ0lH1UbM+oeNrUQw3PTteSQ EB6nwxuL/S1qhFNTqMndK5xx2Mcuk/i0hoet/0Nn+E3EIKOd4f1EwlyTws/KlmHDybk1Be WMFKKmgGth7zCjXOR0njIknjvbLPidI= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-ZE4vIKOaNrCk6TGTAxrkiw-1; Thu, 30 Dec 2021 07:34:15 -0500 X-MC-Unique: ZE4vIKOaNrCk6TGTAxrkiw-1 Received: by mail-ed1-f71.google.com with SMTP id z3-20020a05640240c300b003f9154816ffso7884436edb.9 for ; Thu, 30 Dec 2021 04:34:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Ut4wgPb7k5x4/Ao0enPwI8WZ94CXIktnwuIhAN3PoC8=; b=q+dHJXPjuUflm8vo2mwFYWAj3WSzEM4U29uy+BMLyYR8e835cPRpc79v0IUy8G0ckZ y3329pE6+5SevH8POn1PNiBbHXOMMrmwGNtf5URGSGYFCq9668heBRXdAvzoQ7MV/w1O fARqqlXbXDhpIUuahvm/BSb0KkL+VvSzQYo+qK58w0LMNkjft6dNQHl5+gdLHo8LmfV7 WDXgBtk2+033F71/qm9VrQJYttg/NocWyhJYR2RypMOf3XMOuoC3RF1U6rVgLKC7pCZL RsM2E9NyETeWY89fBrjXW5ZIiSgo9iHuveAM+asAMkMv+lVK8iYH0i4gznTWoJhzEUbX N70w== X-Gm-Message-State: AOAM5314eaTGjyigS2nbqZp6TQJ1PxLdbc40KeGxlu816yF+kX18dFbE DV4pmCtTXdbls7YKBKVjM2qG1kKetDpx66fwLSVxbrdZJKMdiO2yVnzd+zf69hD/TvLDJb+STJd 73EusyRP4UfKyM4gXjcuS X-Received: by 2002:a17:906:4407:: with SMTP id x7mr24120214ejo.51.1640867653939; Thu, 30 Dec 2021 04:34:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJxzmnjnx4eSy7lbaE43bW3/7p+qVtytMv1zH5egd5JLWaMS/r/RUe/rAah2zABTS6qH1ctxUQ== X-Received: by 2002:a17:906:4407:: with SMTP id x7mr24120207ejo.51.1640867653805; Thu, 30 Dec 2021 04:34:13 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id cn8sm9422998edb.13.2021.12.30.04.34.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Dec 2021 04:34:13 -0800 (PST) Message-ID: <0a8e5ec6-5739-5391-deb0-df65b7e01e61@redhat.com> Date: Thu, 30 Dec 2021 13:34:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 02/12] i2c: acpi: Do not instantiate I2C-clients on boards with known bogus DSDT entries Content-Language: en-US To: Wolfram Sang , "Rafael J . Wysocki" , Mark Gross , Andy Shevchenko , Mika Westerberg , Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Len Brown , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org, Stephan Gerhold , linux-serial@vger.kernel.org References: <20211229231431.437982-1-hdegoede@redhat.com> <20211229231431.437982-3-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi, On 12/30/21 13:21, Wolfram Sang wrote: > > Okay, I have a question, after all :) > >> +static const struct acpi_device_id i2c_acpi_known_good_ids[] = { >> + { "10EC5640", 0 }, /* RealTek ALC5640 audio codec */ >> + { "INT33F4", 0 }, /* X-Powers AXP288 PMIC */ >> + { "INT33FD", 0 }, /* Intel Crystal Cove PMIC */ >> + { "NPCE69A", 0 }, /* Asus Transformer keyboard dock */ >> + {} >> +}; > > Can't we add this table to patch 1 and check it within a > acpi_quirk_skip_i2c_client_enumeration(adev)? Yes that will keep all the quirk-handling / ugliness together in a single place, so that is good idea. I will change this for v2 of the series. Regards, Hans