From: Markus Elfring <Markus.Elfring@web.de>
To: make24@iscas.ac.cn, linux-i2c@vger.kernel.org,
Andi Shyti <andi.shyti@kernel.org>,
Elie Morisse <syniurge@gmail.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Wolfram Sang <wsa@kernel.org>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] i2c: fix reference leak in MP2 PCI device
Date: Sun, 28 Sep 2025 13:00:13 +0200 [thread overview]
Message-ID: <0cfce9e4-b84d-41c8-824d-3e1c53d4b6b2@web.de> (raw)
In-Reply-To: <20250928071933.1627-1-make24@iscas.ac.cn>
> In i2c_amd_probe(), amd_mp2_find_device() utilizes
> driver_find_next_device() which internally calls driver_find_device()
> to locate the matching device. driver_find_device() increments the
> reference count of the found device by calling get_device(), but
> amd_mp2_find_device() fails to call put_device() to decrement the
> reference count before returning. This results in a reference count
> leak of the PCI device each time i2c_amd_probe() is executed, which
> may prevent the device from being properly released and cause a memory
> leak.
Under which circumstances would you become interested to apply an attribute
like “__free(put_device)”?
https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/device.h#L1180
Regards,
Markus
next prev parent reply other threads:[~2025-09-28 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 7:19 [PATCH v2] i2c: fix reference leak in MP2 PCI device Ma Ke
2025-09-28 11:00 ` Markus Elfring [this message]
2025-09-28 15:50 ` Greg KH
2025-10-01 23:56 ` Andi Shyti
2025-10-02 0:04 ` Andi Shyti
2025-10-02 12:45 ` Ma Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cfce9e4-b84d-41c8-824d-3e1c53d4b6b2@web.de \
--to=markus.elfring@web.de \
--cc=Shyam-sundar.S-k@amd.com \
--cc=akpm@linux-foundation.org \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=stable@vger.kernel.org \
--cc=syniurge@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox