From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235C3C433EF for ; Thu, 16 Sep 2021 10:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 005036121F for ; Thu, 16 Sep 2021 10:52:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237216AbhIPKyA (ORCPT ); Thu, 16 Sep 2021 06:54:00 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:41232 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235487AbhIPKx7 (ORCPT ); Thu, 16 Sep 2021 06:53:59 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 714C83F077 for ; Thu, 16 Sep 2021 10:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631789558; bh=4Lgdn0Ixo4EbM/31cJClCQJWWjH8/3D1avitifyopTc=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=KMoIjDlLhdEMs5JE3kO5P1k5c11sBEz7LrWCUXbztNSipnZADfb0fhItn1T0B5s0d eUP7fx89zxd+F0J83LovwUCIVBKVovvPmxt2GYLAy0ztatLWQkYRcNPa8bQufbImxB FBO704FbpqbZDt07uT7Eunz1nRtj2pap+BuIkYPil+oTCFXIhZbTScdKF3xCclodFe mdDyWR+fPsbhKFyEo3B6FEfAfyiCLhe2Z8CMaWCZ2IK9VmkKdYytt1/jyVCBg9L4zr tqNfAmpB9c3i7nQtfsCcAtUXHnjQDyd+WzoNFLU0pqzNF6YteBSbkd/irMhKwqgeYt xDD38ehX/agvg== Received: by mail-ed1-f69.google.com with SMTP id r7-20020aa7c147000000b003d1f18329dcso4994227edp.13 for ; Thu, 16 Sep 2021 03:52:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Lgdn0Ixo4EbM/31cJClCQJWWjH8/3D1avitifyopTc=; b=mu9TAu/WSSboVZWuLEPIwlXY9ab+GrLVZsITtoebYPQE+BGeQshJlVYH8A/h9c7fbP zzfpPs3bs4RI0DGAa6ZV55hkQ12FXaFX/dDHsoX5oNp2ZZQXky9l53ysFqjAhJmIFCbc n45nt+UOU/sD+EwuuqxgKPcGinC9npDyTDUdNCljk8xY4ZLhN6PujC2rJjaICTJKuSXQ ax8YX6p98uOcGJXDai4els/MwYJop34n2mhwXU/x4p/L0ybQ8oWHgAedr811UGwOfQb8 lEGX2fPL7VeTqavlCd+Qw8fQawVy7Ge6pZkPjMd5R19tYGjEOdIO9nZuXQfZMlVXs6hg himw== X-Gm-Message-State: AOAM530sjNTidlXAefytWP5JuL/VWBMb+K2+1z6siY/c2RQebRdD/ToW p2Ig7d7PFQ0opmjQqMssYaQI+lhFXBvoFb/wXdhSbYsG6LsYCibzpkmwiyXGCuzhkW6Y9Lap7Oh 3Dq+8O0u/LomLzD73bRAfSXK0G09GI64O3vhBhQ== X-Received: by 2002:a17:906:4413:: with SMTP id x19mr5475678ejo.234.1631789558220; Thu, 16 Sep 2021 03:52:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGfx6w0ppmn0HpLTJ+dsV03ZGRjBHau0aYhh2Ng8iIcPUHpQyfZSlfhi3RuYMMxWbYjlibTg== X-Received: by 2002:a17:906:4413:: with SMTP id x19mr5475670ejo.234.1631789558079; Thu, 16 Sep 2021 03:52:38 -0700 (PDT) Received: from [192.168.3.211] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id d16sm1244793edu.8.2021.09.16.03.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 03:52:37 -0700 (PDT) Subject: Re: [PATCH] i2c: s3c2410: Delete unneeded variable: "ret" To: Xiang wangx Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210916103718.29956-1-wangxiang@cdjrlc.com> From: Krzysztof Kozlowski Message-ID: <0d1a0027-e74d-9f07-3b96-372b5ca14ae3@canonical.com> Date: Thu, 16 Sep 2021 12:52:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210916103718.29956-1-wangxiang@cdjrlc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 16/09/2021 12:37, Xiang wangx wrote: > variable: "ret" defined but not used in function "i2c_s3c_irq_nextbyte" > > Signed-off-by: Xiang wangx > --- > drivers/i2c/busses/i2c-s3c2410.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index b49a1b170bb2..6df85b23156c 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -385,7 +385,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) > { > unsigned long tmp; > unsigned char byte; > - int ret = 0; > > switch (i2c->state) { > > @@ -548,7 +547,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) > tmp &= ~S3C2410_IICCON_IRQPEND; > writel(tmp, i2c->regs + S3C2410_IICCON); > out: > - return ret; > + return 0; Change is okay but I would go step further - made the function return void(). None of the callers check for return so no functionality is lost. Best regards, Krzysztof