Re: [PATCH] media: qcom: camss: Enable setting the rate to camnoc_rt_axi clock

Bryan O'Donoghue
2025-10-16T11:50:12Z

On 16/10/2025 12:30, Konrad Dybcio wrote:
> On 10/16/25 7:54 AM, Krzysztof Kozlowski wrote:
>> On 15/10/2025 04:43, Hangxiang Ma wrote:
>>> On hardware architectures where a single CAMNOC module is split into
>>> two, one for each of the real time (RT) and non real time (NRT) modules
>>> within camera sub system, processing VFE output over the AXI bus
>>> requires enabling and setting the appropriate clock rate for the RT
>>> CAMNOC. This change lays the groundwork for supporting such
>>> configurations.
>>>
>>> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
>>> ---
>>> This change lays the groundwork for supporting configurations for
>>> hardware architectures that split a single CAMNOC module into real time
>>> (RT) and non real time (NRT).
>>> ---
>>> drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
>>> index ee08dbbddf88..09b29ba383f1 100644
>>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
>>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
>>> @@ -914,7 +914,8 @@ static int vfe_match_clock_names(struct vfe_device *vfe,
>>> return (!strcmp(clock->name, vfe_name) ||
>>> !strcmp(clock->name, vfe_lite_name) ||
>>> !strcmp(clock->name, "vfe_lite") ||
>>> - !strcmp(clock->name, "camnoc_axi"));
>>> + !strcmp(clock->name, "camnoc_axi") ||
>>> + !strcmp(clock->name, "camnoc_rt_axi"));
>>
>> Just use camnoc_axi for both. Look at your bindings - why do you keep
>> different names for same signal?
>
> I think the correct question to ask is:
>
> Is camnoc_axi going to represent the other (NRT) clock in this
> setting?
>
> Konrad

I'm - perhaps naively - assuming this clock really is required ... and
that both will be needed concurrently.

---
bod