Re: [PATCH v4 5/6] i2c: smbus: Support DDR5 SPD EEPROMs

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Guenter,


Am 18.06.24 um 20:16 schrieb Guenter Roeck:
> On 6/18/24 08:25, Paul Menzel wrote:

>> Am 18.06.24 um 17:10 schrieb Guenter Roeck:
>>> On 6/18/24 07:59, Paul Menzel wrote:
>>> [ ... ]
>>>
>>>> I did
>>>>
>>>>      $ tail -3 /etc/sensors3.conf
>>>>      chip "spd5118-*"
>>>>          set temp1_max 56000
>>>>          set temp1_crit 84000
>>>>
>>>> but it stays with the defaults:
>>>>
>>>> ```
>>>> $ sensors
>>>> spd5118-i2c-0-53
>>>> Adapter: SMBus I801 adapter at efa0
>>>> temp1:        +20.8°C  (low  =  +0.0°C, high = +55.0°C)
>>>>                         (crit low =  +0.0°C, crit = +85.0°C)
>>>>
>>>
>>> You'd have to write directly into the attribute files.
>>> For example, if you have
>>>
>>> $ grep . /sys/class/hwmon/*/name
>>> /sys/class/hwmon/hwmon0/name:nvme
>>> /sys/class/hwmon/hwmon1/name:nct6687
>>> /sys/class/hwmon/hwmon2/name:k10temp
>>> /sys/class/hwmon/hwmon3/name:spd5118
>>> /sys/class/hwmon/hwmon4/name:spd5118
>>> /sys/class/hwmon/hwmon5/name:spd5118
>>> /sys/class/hwmon/hwmon6/name:spd5118
>>> /sys/class/hwmon/hwmon7/name:mt7921_phy0
>>> /sys/class/hwmon/hwmon8/name:amdgpu
>>>
>>> you could run
>>>
>>> sudo bash -c 'echo 56000 > /sys/class/hwmon/hwmon3/temp1_max'
>>
>>      $ sudo bash -c 'echo 56000 > /sys/class/hwmon/hwmon3/temp1_max'
>>      bash: line 1: echo: write error: No such device or address
>>
> 
> Please add
> 
>      .use_single_write = true,
> 
> to the regmap configuration (spd5118_regmap_config) to see if it helps.

Unfortunately, it does not:

     $ git log --no-decorate -p -1
     commit c27ae51b689d7bdb7baf10c434438d501bd384aa
     Author: Paul Menzel <pmenzel@molgen.mpg.de>
     Date:   Tue Jun 18 20:26:17 2024 +0200

         hwmon: spd5118: Use .use_single_write = true,

     diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c
     index ac94a67793605..33a628840597e 100644
     --- a/drivers/hwmon/spd5118.c
     +++ b/drivers/hwmon/spd5118.c
     @@ -522,6 +522,7 @@ static const struct regmap_config 
spd5118_regmap_config = {
             .writeable_reg = spd5118_writeable_reg,
             .volatile_reg = spd5118_volatile_reg,
             .cache_type = REGCACHE_MAPLE,
     +       .use_single_write = true,
      };

      static int spd5118_probe(struct i2c_client *client)

     $ uname -r
     6.10.0-rc4.mx64.461-00048-gc27ae51b689d
     $ sudo bash -c 'echo 56000 > /sys/class/hwmon/hwmon3/temp1_max'
     bash: line 1: echo: write error: No such device or address


Kind regards,

Paul