From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
wangyouwan <wangyouwan@126.com>
Cc: andriy.shevchenko@linux.intel.com, jsd@semihalf.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: fix crash with msgs is NULL points
Date: Thu, 11 May 2023 10:01:02 +0300 [thread overview]
Message-ID: <11d3a7e2-557f-4f4f-333a-f6cd1b8e6db8@linux.intel.com> (raw)
In-Reply-To: <20230510092344.GP66750@black.fi.intel.com>
Hi
On 5/10/23 12:23, Mika Westerberg wrote:
>
> On Wed, May 10, 2023 at 05:17:04PM +0800, wangyouwan wrote:
>> After waking up from sleep, 100% of the time it occurred. I suspected
>> that there was a firmware issue with the machine I was debugging, but
>> other machines did not notice it. Therefore, I attempted to make a
>> modification here to avoid it
>
> Okay then I suggest to investigate what causes the ->msgs to be NULL and
> fix that. When the transfer function is called we expect there to be
> something to be sent out so this should not happen.
Does you kernel include commit 301c8f5c32c8 ("i2c: designware: Fix
handling of real but unexpected device interrupts")? Vanilla kernels
after v6.1 have it and also linux-stable v5.15.75 and after.
I'm asking since issue sounds similar and wanted to clarify the kernel
version you are using.
prev parent reply other threads:[~2023-05-11 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 8:40 [PATCH] i2c: fix crash with msgs is NULL points wangyouwan
2023-05-10 9:02 ` Mika Westerberg
[not found] ` <1943ca04.6ce1.18804f327f0.Coremail.wangyouwan@126.com>
2023-05-10 9:23 ` Mika Westerberg
2023-05-11 7:01 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11d3a7e2-557f-4f4f-333a-f6cd1b8e6db8@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wangyouwan@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox