* [PATCH] i2c-s3c2410: s3c24xx_i2c_init: don't clobber IICLC value
@ 2009-07-17 20:33 Peter Korsgaard
[not found] ` <1247862817-17106-1-git-send-email-jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2009-07-17 20:33 UTC (permalink / raw)
To: ben-linux-elnMNo+KYs3YtjvyW6yDsg,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: Peter Korsgaard
s3c24xx_i2c_init() was overwriting the IICLC value set just above in
s3c24xx_i2c_clockrate() with zero, effectively disabling the platform
line control setting.
Signed-off-by: Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
---
drivers/i2c/busses/i2c-s3c2410.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 8f42a45..20bb0ce 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -763,11 +763,6 @@ static int s3c24xx_i2c_init(struct s3c24xx_i2c *i2c)
dev_info(i2c->dev, "bus frequency set to %d KHz\n", freq);
dev_dbg(i2c->dev, "S3C2410_IICCON=0x%02lx\n", iicon);
- /* check for s3c2440 i2c controller */
-
- if (s3c24xx_i2c_is2440(i2c))
- writel(0x0, i2c->regs + S3C2440_IICLC);
-
return 0;
}
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c-s3c2410: s3c24xx_i2c_init: don't clobber IICLC value
[not found] ` <1247862817-17106-1-git-send-email-jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
@ 2009-07-24 8:33 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2009-07-24 8:33 UTC (permalink / raw)
To: ben-linux-elnMNo+KYs3YtjvyW6yDsg; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA
>>>>> "Peter" == Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org> writes:
Peter> s3c24xx_i2c_init() was overwriting the IICLC value set just
Peter> above in s3c24xx_i2c_clockrate() with zero, effectively
Peter> disabling the platform line control setting.
ping?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-24 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-17 20:33 [PATCH] i2c-s3c2410: s3c24xx_i2c_init: don't clobber IICLC value Peter Korsgaard
[not found] ` <1247862817-17106-1-git-send-email-jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
2009-07-24 8:33 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).