Re: [PATCH v6] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt

Kevin Hilman
2010-04-28T14:17:48Z

Nishanth Menon <nm@ti.com> writes:

> very minor comments below:
> On 04/28/2010 12:47 AM, G, Manjunath Kondaiah wrote:

[...]

>> struct omap_i2c_dev {
>> struct device *dev;
>> @@ -199,6 +201,7 @@ struct omap_i2c_dev {
>> u16 bufstate;
>> u16 syscstate;
>> u16 westate;
>> + u16 errata;
> overall I'd prefer the term quirk over errata - quirk is more of a
> standard linux term used accross network, usb and other drivers, will
> allow the code to be a little more familiar with the upstream
> maintainers/reviewers.. but i leave it to tony and others to comment
> more.. maybe it is just me being an ass again ;)

I prefer the term errata since it is also the term used by TI docs.

Kevin