Re: [PATCH v6] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt

Nishanth Menon
2010-04-28T10:22:59Z

On 04/28/2010 05:20 AM, G, Manjunath Kondaiah wrote:
[..]

>>>
>>> + dev->errata = 0;
>>> +
>>> + if (cpu_is_omap2430() || cpu_is_omap34xx())
>> ^^^^^^^^ wont cpu_is_omap24xx() cover omap2420 as
>> well? I think it might be better using that.. apologies on
>> missing it in
>> the last look.
>
> This errata is not applicable for 2420 and it is applicable for:
> 1. omap2430
> 2. omap34xx(including omap3630).
>
> Sorry. My earlier patch was using this errata logic for all omap's
> except omap4 which was wrong(for omap2420 and omap1 - not sure, I don't have
> any data hence ignoring this errata for omap1 also).
>
Could you fix your commit message to state so instead of using OMAP2?
thanks.. I think we are almost close to the final rev is Tony is ok as
well.. Thanks for hanging in there..

[...]
Regards,
Nishanth Menon