From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors Date: Mon, 12 Jul 2010 16:07:41 -0700 Message-ID: <1278976061.11618.147.camel@groeck-laptop> References: <1278859984-22593-1-git-send-email-guenter.roeck@ericsson.com> <20100712154949.3230beec.akpm@linux-foundation.org> Reply-To: guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100712154949.3230beec.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Morton Cc: Jean Delvare , Randy Dunlap , Hans de Goede , Mark Brown , Samuel Ortiz , Joe Perches , "David S. Miller" , Paul Goyette , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Mon, 2010-07-12 at 18:49 -0400, Andrew Morton wrote: > On Sun, 11 Jul 2010 07:53:04 -0700 > Guenter Roeck wrote: > > > +static int jc42_probe(struct i2c_client *new_client, > > + const struct i2c_device_id *id) > > +{ > > + struct jc42_data *data; > > + int config, cap, err; > > + > > + data = kzalloc(sizeof(struct jc42_data), GFP_KERNEL); > > + if (!data) { > > + err = -ENOMEM; > > + goto exit; > > + } > > + > > + i2c_set_clientdata(new_client, data); > > + data->valid = false; > > I think it would be acceptable to assume that memset(..., 0, ...) sets > a bool to `false' ;) > Guess so. Wonder where I got that from. Thanks for noticing... Guenter