From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Manikanta Maddireddy <mmaddireddy@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time
Date: Mon, 27 Apr 2020 19:02:05 +0300 [thread overview]
Message-ID: <127a2c32-e5fb-2944-3062-361b276490c0@gmail.com> (raw)
In-Reply-To: <20200427153244.GF3464906@ulmo>
27.04.2020 18:32, Thierry Reding пишет:
> On Mon, Apr 27, 2020 at 12:50:29PM +0200, Thierry Reding wrote:
>> On Mon, Apr 27, 2020 at 12:35:53PM +0200, Wolfram Sang wrote:
>>> On Mon, Apr 27, 2020 at 12:07:19PM +0300, Dmitry Osipenko wrote:
>>>> 27.04.2020 11:44, Wolfram Sang пишет:
>>>>>
>>>>>> Wolfram, can you revert the following two patches for v5.7, please?
>>>>>>
>>>>>> 8814044fe0fa i2c: tegra: Synchronize DMA before termination
>>>>
>>>> This patch has nothing to do with your trouble, why do you want to
>>>> revert it?
>>>
>>> I'll wait some more before pushing out, so you can discuss it.
>>
>> Okay, let me run a quick test with that second patch still applied to
>> make sure it really is harmless.
>
> Alright, I tested v5.7-rc3 with this patch reverted:
>
> a900aeac2537 i2c: tegra: Better handle case where CPU0 is busy for a long time
>
> and the results came back positive, so I think we can leave patch:
>
> 8814044fe0fa i2c: tegra: Synchronize DMA before termination
>
> in. But then again, I see that Dmitry posted this yesterday:
>
> https://lkml.org/lkml/2020/4/26/481
>
> which seems like it would be related to this and potentially be a
> follow-up fix for some corner cases?
This is a follow-up to my previous message in this thread:
https://lkml.org/lkml/2020/4/23/792
> So I'm not sure how well this whole set has been tested yet.
It depends on what you're meaning by the testing. We have some
yet-out-of-tree real-world devices that are using APBDMA for Bluetooth,
Audio, I2C (touchscreens) and etc peripherals. These devices were using
the DMA patches before they were posted to the ML.
> Maybe a better solution would be for the DMA synchronization patch to go
> into the 5.8 queue instead to make sure we get more testing cycles.
It should be fine to re-queue the patches for 5.8. I'm just a bit afraid
that if patches are simply dropped now, then you won't get back to it
for a year or so ;)
next prev parent reply other threads:[~2020-04-27 16:02 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 19:12 [PATCH v2 0/2] NVIDIA Tegra I2C synchronization correction Dmitry Osipenko
2020-03-24 19:12 ` [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time Dmitry Osipenko
2020-04-15 16:31 ` Wolfram Sang
2020-04-20 19:53 ` Jon Hunter
2020-04-20 22:11 ` Dmitry Osipenko
2020-04-21 0:32 ` Dmitry Osipenko
2020-04-21 9:49 ` Jon Hunter
2020-04-21 12:39 ` Manikanta Maddireddy
2020-04-21 13:08 ` Jon Hunter
2020-04-21 13:49 ` Manikanta Maddireddy
2020-04-21 13:25 ` Dmitry Osipenko
2020-04-21 14:40 ` Jon Hunter
2020-04-21 15:08 ` Dmitry Osipenko
2020-04-21 19:42 ` Jon Hunter
2020-04-22 13:40 ` Dmitry Osipenko
2020-04-22 13:59 ` Jon Hunter
2020-04-22 14:07 ` Dmitry Osipenko
2020-04-23 10:56 ` Jon Hunter
2020-04-23 16:33 ` Dmitry Osipenko
2020-04-24 7:10 ` Jon Hunter
2020-04-24 14:45 ` Dmitry Osipenko
2020-04-24 15:19 ` Jon Hunter
2020-04-27 7:48 ` Thierry Reding
2020-04-27 8:44 ` Wolfram Sang
2020-04-27 9:07 ` Dmitry Osipenko
2020-04-27 10:35 ` Wolfram Sang
2020-04-27 10:50 ` Thierry Reding
2020-04-27 15:32 ` Thierry Reding
2020-04-27 16:02 ` Dmitry Osipenko [this message]
2020-04-27 10:49 ` Thierry Reding
2020-04-27 9:52 ` Dmitry Osipenko
2020-04-27 10:38 ` Wolfram Sang
2020-04-27 13:15 ` Dmitry Osipenko
2020-04-27 14:19 ` Thierry Reding
2020-04-27 15:31 ` Wolfram Sang
2020-05-02 14:40 ` Dmitry Osipenko
2020-05-02 14:43 ` Wolfram Sang
2020-05-04 15:42 ` Thierry Reding
2020-05-04 20:55 ` Dmitry Osipenko
2020-04-27 11:00 ` Thierry Reding
2020-04-27 14:21 ` Dmitry Osipenko
2020-04-27 15:12 ` Thierry Reding
2020-04-27 15:18 ` Dmitry Osipenko
2020-04-28 8:01 ` Jon Hunter
2020-04-28 12:37 ` Dmitry Osipenko
2020-04-29 8:14 ` Thierry Reding
2020-04-29 8:55 ` Thierry Reding
2020-04-29 12:35 ` Dmitry Osipenko
2020-04-29 13:57 ` Jon Hunter
2020-04-29 14:46 ` Dmitry Osipenko
2020-04-29 16:24 ` Thierry Reding
2020-04-29 17:02 ` Dmitry Osipenko
2020-04-29 16:30 ` Thierry Reding
2020-04-29 16:54 ` Dmitry Osipenko
2020-04-29 17:34 ` Dmitry Osipenko
2020-04-27 12:46 ` Dmitry Osipenko
2020-04-27 14:13 ` Dmitry Osipenko
2020-04-27 14:45 ` Dmitry Osipenko
2020-04-27 15:38 ` Dmitry Osipenko
2020-04-28 8:02 ` Jon Hunter
2020-04-28 23:12 ` Dmitry Osipenko
2020-04-21 15:18 ` Dmitry Osipenko
2020-04-21 15:34 ` Jon Hunter
2020-04-21 19:07 ` Dmitry Osipenko
2020-04-28 13:43 ` Dmitry Osipenko
2020-03-24 19:12 ` [PATCH v2 2/2] i2c: tegra: Synchronize DMA before termination Dmitry Osipenko
2020-04-15 16:31 ` Wolfram Sang
2020-04-15 11:45 ` [PATCH v2 0/2] NVIDIA Tegra I2C synchronization correction Wolfram Sang
2020-04-15 14:14 ` Dmitry Osipenko
2020-04-15 16:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=127a2c32-e5fb-2944-3062-361b276490c0@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).