From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org"
<jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
Andrew Chew <AChew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org"
<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: RE: [PATCH v2] iio: light: Adding driver for ISL29018 ALS
Date: Tue, 05 Oct 2010 14:41:43 -0700 [thread overview]
Message-ID: <1286314903.2156.54.camel@Joe-Laptop> (raw)
In-Reply-To: <E88A1D35AF5437468E5B14C7C4BA61C702D2D2620A-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
On Tue, 2010-10-05 at 14:36 -0700, Rhyland Klein wrote:
> > -----Original Message-----
> > From: Joe Perches [mailto:joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org]
> > > diff --git a/drivers/staging/iio/light/isl29018.c
> > b/drivers/staging/iio/light/isl29018.c
> > > +static int isl29018_chip_init(struct i2c_client *client)
> > > +{
> > > + struct isl29018_chip *chip = i2c_get_clientdata(client);
> > > + int status;
> > > + int i;
> > > + int new_adc_bit;
> > > + unsigned int new_range;
> > > +
> > > + for (i = 0; i < ARRAY_SIZE(chip->reg_cache); i++)
> > > + chip->reg_cache[i] = 0;
> > memset?
> I could use memset, except this is only 4 registers = 32 bytes,
> so I don't think that is really worth it do you?
Your choice. I don't care really. I didn't look to
see how many elements were in chip->reg_cache.
I just noted it as whenever I see a loop initialization
like that, I think memset not loop.
cheers, Joe
prev parent reply other threads:[~2010-10-05 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 21:19 [PATCH v2] iio: light: Adding driver for ISL29018 ALS rklein-DDmLM1+adcrQT0dZR+AlfA
[not found] ` <1286313561-6456-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2010-10-05 21:35 ` Joe Perches
2010-10-05 21:36 ` Rhyland Klein
[not found] ` <E88A1D35AF5437468E5B14C7C4BA61C702D2D2620A-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2010-10-05 21:41 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286314903.2156.54.camel@Joe-Laptop \
--to=joe-6d6dil74uinbdgjk7y7tuq@public.gmane.org \
--cc=AChew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox