From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2] i2c/mux: Driver for PCA9541 I2C Master Selector Date: Tue, 19 Oct 2010 14:59:19 -0700 Message-ID: <1287525559.9690.309.camel@groeck-laptop> References: <1286932516-20689-1-git-send-email-guenter.roeck@ericsson.com> <20101019190647.314302e7@endymion.delvare> <1287521453.9690.299.camel@groeck-laptop> <20101019234929.3d4d14f4@endymion.delvare> Reply-To: guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101019234929.3d4d14f4-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: Ben Dooks , Rodolfo Giometti , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Tue, 2010-10-19 at 17:49 -0400, Jean Delvare wrote: > On Tue, 19 Oct 2010 13:50:53 -0700, Guenter Roeck wrote: > > Hi Jean, > > > > On Tue, 2010-10-19 at 13:06 -0400, Jean Delvare wrote: > > [ ... ] > > > > + > > > > +/* > > > > + * I2C init/probing/exit functions > > > > + */ > > > > +static int __devinit pca9541_probe(struct i2c_client *client, > > > > + const struct i2c_device_id *id) > > > > > > The use of __devinit and __devexit isn't recommended for i2c drivers. > > > If your driver is built into the kernel but the underlying i2c bus > > > driver is build as a module, you're in trouble. > > > > > I don't mind changing this, but ... the code is copied from pca954x.c, > > which also uses __devinit and __devexit for the same functions. Wouldn't > > that be a problem there as well ? Or am I missing something ? > > You're right, this should be fixed. I take patches ;) > Ok, I'll add that to my pending list. Guenter