Re: [PATCH 12/12] hwmon: lis3: Release resources is case of failure

Éric Piel
2010-10-24T14:59:23Z

Op 22-10-10 13:57, Samu Onkalo schreef:
> If lis3lv02d_init_device fails, HW resources were not released
> properly. In case of failure call release_resources if available.
>
> Signed-off-by: Samu Onkalo<samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Acked-by: Eric Piel <eric.piel-VkQ1JFuSMpfAbQlEx87xDw@public.gmane.org>
> ---
> drivers/hwmon/lis3lv02d_i2c.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/lis3lv02d_i2c.c b/drivers/hwmon/lis3lv02d_i2c.c
> index 61c109b..94d5bde 100644
> --- a/drivers/hwmon/lis3lv02d_i2c.c
> +++ b/drivers/hwmon/lis3lv02d_i2c.c
> @@ -161,7 +161,12 @@ static int __devinit lis3lv02d_i2c_probe(struct i2c_client *client,
>
> if (lis3_dev.reg_ctrl)
> lis3_reg_ctrl(&lis3_dev, LIS3_REG_OFF);
> +
> + if (ret == 0)
> + return 0;
> fail:
> + if (pdata&& pdata->release_resources)
> + pdata->release_resources();
> return ret;
> }
>