Re: [PATCH 1/2] i2c-i801: Handle multiple instances instead of keeping global state

[David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>]

On Sun, 2010-10-31 at 00:39 +0100, Ben Dooks wrote:
> On Sat, Oct 30, 2010 at 07:34:23PM -0400, David Woodhouse wrote:
> > On Sat, 2010-10-30 at 18:24 +0200, Jean Delvare wrote:
> > > An explanation why this change is needed would be nice.
> > 
> > Um, does it really need explaining? It's really poor form to keep driver
> > state in global variables rather than per-instance, even if you *don't*
> > actually have more than one device.
> 
> I always like to fill it in, it makes it easier for lazy folks who can't
> be bothered to read the patch itself.

The explanation fits in one line:
  "Handle multiple instances instead of keeping global state"

I could try adding a paragraph explaining further that this patch will
make the driver handle multiple instances of the device, by keeping its
state per-device instead of in global variables. But that seems
somewhat... redundant.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org                              Intel Corporation