Re: [PATCH 2/2] i2c-i801: Add PCI idents for Patsburg 'IDF' SMBus controllers

Jean Delvare
2010-10-31T20:11:59Z

On Sun, 31 Oct 2010 11:24:12 -0400, David Woodhouse wrote:
> These are the extra 'Integrated Device Function' SMBus controllers found
> on the Patsburg chipset. Mention the absence of slave mode support.
>
> Signed-off-by: David Woodhouse <David.Woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> Seth already added the host controller ID, calling it 'Patsburg'. So
> I'll call it 'Patsburg' too, and just add the additional controllers.

Applied, thanks.

>
> We should probably add a column in the hardware support table indicating
> which devices support slave mode. The Patsburg host does; the IDF
> controllers don't. Not sure how many older devices have slave mode.

I agree. Feel free to only add the yes/no flag in that column for the
devices for which you know the answer, and we can populate the rest
later. All the datasheets are available so it should be doable although
this will take some time due to the large number of supported devices.

That being said, this column will really only start being interesting
if/when we actually implement support for the slave mode. Not sure who
needs this.

--
Jean Delvare