* [PATCH] I2C: Add support for 64bit system.
@ 2010-12-20 7:37 Xulei
[not found] ` <1292830654-7056-1-git-send-email-B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Xulei @ 2010-12-20 7:37 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A, Xulei
Currently I2C_MPC supports 32bit system only, then this
modification makes it support 32bit and 64bit system both.
Signed-off-by: Xulei <B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
drivers/i2c/busses/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 9c6170c..3392f4b 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -422,7 +422,7 @@ config I2C_IXP2000
config I2C_MPC
tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx"
- depends on PPC32
+ depends on PPC32 || PPC64
help
If you say yes to this option, support will be included for the
built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1292830654-7056-1-git-send-email-B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]
* Re: [PATCH] I2C: Add support for 64bit system. [not found] ` <1292830654-7056-1-git-send-email-B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org> @ 2010-12-20 14:59 ` Ben Dooks [not found] ` <20101220145954.GA1126-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Ben Dooks @ 2010-12-20 14:59 UTC (permalink / raw) To: Xulei; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote: > Currently I2C_MPC supports 32bit system only, then this > modification makes it support 32bit and 64bit system both. > > Signed-off-by: Xulei <B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org> This been build or run tested? > --- > drivers/i2c/busses/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 9c6170c..3392f4b 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -422,7 +422,7 @@ config I2C_IXP2000 > > config I2C_MPC > tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx" > - depends on PPC32 > + depends on PPC32 || PPC64 > help > If you say yes to this option, support will be included for the > built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx, > -- > 1.7.0.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20101220145954.GA1126-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>]
* Re: [PATCH] I2C: Add support for 64bit system. [not found] ` <20101220145954.GA1126-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org> @ 2010-12-21 7:32 ` xulei 2011-03-15 15:44 ` Kumar Gala 1 sibling, 0 replies; 6+ messages in thread From: xulei @ 2010-12-21 7:32 UTC (permalink / raw) To: Ben Dooks Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A yes, it has been built and could access the RTC well. On 一, 2010-12-20 at 14:59 +0000, Ben Dooks wrote: > On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote: > > Currently I2C_MPC supports 32bit system only, then this > > modification makes it support 32bit and 64bit system both. > > > > Signed-off-by: Xulei <B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > This been build or run tested? > > > --- > > drivers/i2c/busses/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > > index 9c6170c..3392f4b 100644 > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -422,7 +422,7 @@ config I2C_IXP2000 > > > > config I2C_MPC > > tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx" > > - depends on PPC32 > > + depends on PPC32 || PPC64 > > help > > If you say yes to this option, support will be included for the > > built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx, > > -- > > 1.7.0.4 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] I2C: Add support for 64bit system. [not found] ` <20101220145954.GA1126-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org> 2010-12-21 7:32 ` xulei @ 2011-03-15 15:44 ` Kumar Gala [not found] ` <D9BF0938-44B1-4BB8-BF3C-0A9CB44B9CC5-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> 1 sibling, 1 reply; 6+ messages in thread From: Kumar Gala @ 2011-03-15 15:44 UTC (permalink / raw) To: Ben Dooks Cc: Xulei, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A, linux-i2c-u79uwXL29TY76Z2rM5mHXA On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote: > On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote: >> Currently I2C_MPC supports 32bit system only, then this >> modification makes it support 32bit and 64bit system both. >> >> Signed-off-by: Xulei <B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org> > > This been build or run tested? Yes, Any issues with me applying this via the powerpc.git tree? > >> --- >> drivers/i2c/busses/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 9c6170c..3392f4b 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -422,7 +422,7 @@ config I2C_IXP2000 >> >> config I2C_MPC >> tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx" >> - depends on PPC32 >> + depends on PPC32 || PPC64 >> help >> If you say yes to this option, support will be included for the >> built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx, >> -- >> 1.7.0.4 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/ > > Large Hadron Colada: A large Pina Colada that makes the universe disappear. > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <D9BF0938-44B1-4BB8-BF3C-0A9CB44B9CC5-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>]
* Re: [PATCH] I2C: Add support for 64bit system. [not found] ` <D9BF0938-44B1-4BB8-BF3C-0A9CB44B9CC5-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> @ 2011-03-15 15:56 ` Timur Tabi [not found] ` <AANLkTim0_ttjDPJvx71B-=Ze5dRTrKXfpavx7gxvYr5p-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Timur Tabi @ 2011-03-15 15:56 UTC (permalink / raw) To: Kumar Gala Cc: Ben Dooks, Xulei, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A, linux-i2c-u79uwXL29TY76Z2rM5mHXA On Tue, Mar 15, 2011 at 10:44 AM, Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> wrote: > > On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote: > >> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote: >>> Currently I2C_MPC supports 32bit system only, then this >>> modification makes it support 32bit and 64bit system both. >>> >>> Signed-off-by: Xulei <B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org> >> >> This been build or run tested? > > Yes, Any issues with me applying this via the powerpc.git tree? I'm concerned about the fact that we have to have two defines to declare code that is 32-bit and 64-bit clean. Technically speaking, all drivers should work in both environments. It seems silly to have "PPC32 || PPC64" for everything. Isn't there a generic "PPC" config option that covers this? -- Timur Tabi Linux kernel developer at Freescale ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <AANLkTim0_ttjDPJvx71B-=Ze5dRTrKXfpavx7gxvYr5p-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] I2C: Add support for 64bit system. [not found] ` <AANLkTim0_ttjDPJvx71B-=Ze5dRTrKXfpavx7gxvYr5p-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2011-03-15 16:00 ` Kumar Gala 0 siblings, 0 replies; 6+ messages in thread From: Kumar Gala @ 2011-03-15 16:00 UTC (permalink / raw) To: Timur Tabi Cc: Ben Dooks, Xulei, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A, linux-i2c-u79uwXL29TY76Z2rM5mHXA On Mar 15, 2011, at 10:56 AM, Timur Tabi wrote: > On Tue, Mar 15, 2011 at 10:44 AM, Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> wrote: >> >> On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote: >> >>> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote: >>>> Currently I2C_MPC supports 32bit system only, then this >>>> modification makes it support 32bit and 64bit system both. >>>> >>>> Signed-off-by: Xulei <B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org> >>> >>> This been build or run tested? >> >> Yes, Any issues with me applying this via the powerpc.git tree? > > I'm concerned about the fact that we have to have two defines to > declare code that is 32-bit and 64-bit clean. Technically speaking, > all drivers should work in both environments. It seems silly to have > "PPC32 || PPC64" for everything. Isn't there a generic "PPC" config > option that covers this? There is, I'll post a new patch that uses it. - k-- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-15 16:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-20 7:37 [PATCH] I2C: Add support for 64bit system Xulei
[not found] ` <1292830654-7056-1-git-send-email-B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-12-20 14:59 ` Ben Dooks
[not found] ` <20101220145954.GA1126-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-12-21 7:32 ` xulei
2011-03-15 15:44 ` Kumar Gala
[not found] ` <D9BF0938-44B1-4BB8-BF3C-0A9CB44B9CC5-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-03-15 15:56 ` Timur Tabi
[not found] ` <AANLkTim0_ttjDPJvx71B-=Ze5dRTrKXfpavx7gxvYr5p-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-15 16:00 ` Kumar Gala
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).