From: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Guenter Roeck
<guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
Subject: [PATCH v2 4/6] i2cset: Ensure that there is no junk after the command/mode parameter
Date: Sun, 13 Feb 2011 12:17:24 -0800 [thread overview]
Message-ID: <1297628246-19367-5-git-send-email-guenter.roeck@ericsson.com> (raw)
In-Reply-To: <1297628246-19367-1-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
Since the value mask can no longer be set after the mode command,
we can make sure that there is no junk after the command/mode
parameter in the command line.
Signed-off-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
---
CHANGES | 1 +
tools/i2cset.c | 3 +++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/CHANGES b/CHANGES
index 999ff26..1ffe18f 100644
--- a/CHANGES
+++ b/CHANGES
@@ -5,6 +5,7 @@ SVN
i2c-dev.h: Make value arrays const for block write functions
i2cset: Add support for SMBus and I2C block writes
Remove obsolete means to specify value mask
+ More stringent parameter validation
3.0.3 (2010-12-12)
Makefile: Let the environment set CC and CFLAGS
diff --git a/tools/i2cset.c b/tools/i2cset.c
index bdc16f8..ad7da75 100644
--- a/tools/i2cset.c
+++ b/tools/i2cset.c
@@ -240,6 +240,9 @@ int main(int argc, char *argv[])
block[len] = value;
}
goto dofile;
+ } else if (argc != flags + 6) {
+ fprintf(stderr, "Error: Bad number of arguments!\n");
+ help();
}
}
--
1.7.0.4
next prev parent reply other threads:[~2011-02-13 20:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 20:17 [PATCH v2 0/6] i2cset changes Guenter Roeck
[not found] ` <1297628246-19367-1-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-13 20:17 ` [PATCH v2 1/6] i2cset: Remove deprecated method to provide the value mask Guenter Roeck
[not found] ` <1297628246-19367-2-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-14 8:48 ` Jean Delvare
[not found] ` <20110214094847.6607ebaa-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-02-14 15:46 ` Guenter Roeck
[not found] ` <20110214154610.GA22833-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-14 16:17 ` Jean Delvare
[not found] ` <20110214171735.06270f30-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-02-14 17:09 ` Guenter Roeck
2011-02-13 20:17 ` [PATCH v2 2/6] i2cset: Check number of arguments for block data writes Guenter Roeck
[not found] ` <1297628246-19367-3-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-14 8:52 ` Jean Delvare
2011-02-13 20:17 ` [PATCH v2 3/6] i2cset: Abort if value mask is set for block commands Guenter Roeck
[not found] ` <1297628246-19367-4-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-14 8:56 ` Jean Delvare
2011-02-13 20:17 ` Guenter Roeck [this message]
[not found] ` <1297628246-19367-5-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-14 8:59 ` [PATCH v2 4/6] i2cset: Ensure that there is no junk after the command/mode parameter Jean Delvare
2011-02-13 20:17 ` [PATCH v2 5/6] i2cset: Replace blanks at beginning of line with tabs Guenter Roeck
[not found] ` <1297628246-19367-6-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-14 9:00 ` Jean Delvare
2011-02-13 20:17 ` [PATCH v2 6/6] i2cset: Get command/mode before reading data Guenter Roeck
[not found] ` <1297628246-19367-7-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-14 9:43 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297628246-19367-5-git-send-email-guenter.roeck@ericsson.com \
--to=guenter.roeck-izefyvvap7pwk0htik3j/w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).