From: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
Subject: [PATCH v3 6/6] i2cset: Check range for data value mask
Date: Mon, 14 Feb 2011 10:06:13 -0800 [thread overview]
Message-ID: <1297706773-26389-7-git-send-email-guenter.roeck@ericsson.com> (raw)
In-Reply-To: <1297706773-26389-1-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
Signed-off-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
---
tools/i2cset.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/i2cset.c b/tools/i2cset.c
index ed6ada2..b512081 100644
--- a/tools/i2cset.c
+++ b/tools/i2cset.c
@@ -300,6 +300,11 @@ int main(int argc, char *argv[])
fprintf(stderr, "Error: Data value mask invalid!\n");
help();
}
+ if (((size == I2C_SMBUS_BYTE || size == I2C_SMBUS_BYTE_DATA)
+ && vmask > 0xff) || vmask > 0xffff) {
+ fprintf(stderr, "Error: Data value mask out of range!\n");
+ help();
+ }
}
file = open_i2c_dev(i2cbus, filename, sizeof(filename), 0);
--
1.7.0.4
next prev parent reply other threads:[~2011-02-14 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 18:06 [PATCH v3 0/6] i2cset changes Guenter Roeck
[not found] ` <1297706773-26389-1-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-02-14 18:06 ` [PATCH v2 1/6] i2cset: Remove deprecated method to provide the value mask Guenter Roeck
2011-02-14 18:06 ` [PATCH v3 2/6] i2cset: Check number of arguments for block data writes Guenter Roeck
2011-02-14 18:06 ` [PATCH v2 3/6] i2cset: Abort if value mask is set for block commands Guenter Roeck
2011-02-14 18:06 ` [PATCH v3 4/6] i2cset: Ensure that there is no junk after the command/mode parameter Guenter Roeck
2011-02-14 18:06 ` [PATCH v2 5/6] i2cset: Get command/mode before reading data Guenter Roeck
2011-02-14 18:06 ` Guenter Roeck [this message]
2011-02-15 9:45 ` [PATCH v3 0/6] i2cset changes Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297706773-26389-7-git-send-email-guenter.roeck@ericsson.com \
--to=guenter.roeck-izefyvvap7pwk0htik3j/w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).