From: Ilkka Koskinen <ilkka.koskinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org,
eric.piel-VkQ1JFuSMpfAbQlEx87xDw@public.gmane.org,
samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org
Cc: lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [RFC PATCH 1/5] hwmon: lis3: Free regulators if probe() fails.
Date: Tue, 15 Mar 2011 18:02:41 +0200 [thread overview]
Message-ID: <1300204965-7209-2-git-send-email-ilkka.koskinen@nokia.com> (raw)
In-Reply-To: <1300204965-7209-1-git-send-email-ilkka.koskinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Ilkka Koskinen <ilkka.koskinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
---
drivers/hwmon/lis3lv02d_i2c.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/lis3lv02d_i2c.c b/drivers/hwmon/lis3lv02d_i2c.c
index 8853afc..d834505 100644
--- a/drivers/hwmon/lis3lv02d_i2c.c
+++ b/drivers/hwmon/lis3lv02d_i2c.c
@@ -161,8 +161,13 @@ static int __devinit lis3lv02d_i2c_probe(struct i2c_client *client,
if (lis3_dev.reg_ctrl)
lis3_reg_ctrl(&lis3_dev, LIS3_REG_OFF);
- if (ret == 0)
- return 0;
+ if (ret)
+ goto fail2;
+ return 0;
+
+fail2:
+ regulator_bulk_free(ARRAY_SIZE(lis3_dev.regulators),
+ lis3_dev.regulators);
fail:
if (pdata && pdata->release_resources)
pdata->release_resources();
--
1.7.0.4
next prev parent reply other threads:[~2011-03-15 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 16:02 [RFC PATCH 0/5] hwmon: lis3 patches Ilkka Koskinen
2011-03-15 16:02 ` [RFC PATCH 2/5] hwmon: lis3: Change naming to consistent Ilkka Koskinen
[not found] ` <1300204965-7209-1-git-send-email-ilkka.koskinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2011-03-15 16:02 ` Ilkka Koskinen [this message]
2011-03-15 16:02 ` [RFC PATCH 3/5] hwmon: lis3: Change exported function to use given device Ilkka Koskinen
2011-03-15 16:02 ` [RFC PATCH 4/5] hwmon: lis3: Remove the referencies to the global variable in core driver Ilkka Koskinen
2011-03-15 16:02 ` [RFC PATCH 5/5] hwmon: lis3: Register hwif and remove references to global variable Ilkka Koskinen
2011-03-15 16:16 ` [RFC PATCH 0/5] hwmon: lis3 patches Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300204965-7209-2-git-send-email-ilkka.koskinen@nokia.com \
--to=ilkka.koskinen-xnzwkgviw5gavxtiumwx3w@public.gmane.org \
--cc=eric.piel-VkQ1JFuSMpfAbQlEx87xDw@public.gmane.org \
--cc=guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).