Re: [PATCH] i2c-i801: Don't probe for slaves on IDF channels

["Woodhouse, David" <david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

On Tue, 2011-05-10 at 15:08 +0100, Jean Delvare wrote:
> I don't know if Fujitsu is ever going to produce Patsburg-based
> machines, but if they do, I'd rather not probe the secondary (IDF)
> SMBus channels. At least not until we have a good reason for doing so.

Seems reasonable in principle.

> +#if defined CONFIG_INPUT_APANEL || defined CONFIG_INPUT_APANEL_MODULE

> +#if defined CONFIG_SENSORS_FSCHMD || defined CONFIG_SENSORS_FSCHMD_MODULE

This kind of ifdef is horrid though, and should be avoided at all costs.
A setting of CONFIG_xxx_MODULE should not affect the *static* kernel
image. You should be able to enable an additional module, build it and
use it without having to rebuild/reboot the kernel.

I know there are *some* cases where we violate that rule, but that
doesn't make it any nicer.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org                              Intel Corporation

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6242 bytes --]