From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>
Subject: [PATCH] leds: Remove obsolete cleanup for clientdata
Date: Mon, 20 Jun 2011 23:01:13 +0200 [thread overview]
Message-ID: <1308603674-19264-2-git-send-email-w.sang@pengutronix.de> (raw)
In-Reply-To: <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.
Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>
---
This is more a cleanup than a bugfix. Still, would be happy to have this
obsolete programming style largely removed in 3.0 if possible.
drivers/leds/leds-lm3530.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
index 4d7ce76..59f5604 100644
--- a/drivers/leds/leds-lm3530.c
+++ b/drivers/leds/leds-lm3530.c
@@ -382,7 +382,6 @@ err_class_register:
err_reg_init:
regulator_put(drvdata->regulator);
err_regulator_get:
- i2c_set_clientdata(client, NULL);
kfree(drvdata);
err_out:
return err;
--
1.7.2.5
next prev parent reply other threads:[~2011-06-20 21:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 21:01 [PATCH] input/keyboard: Remove obsolete cleanup for clientdata Wolfram Sang
[not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-20 21:01 ` Wolfram Sang [this message]
[not found] ` <1308603674-19264-2-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-21 8:55 ` [PATCH] leds: " Jean Delvare
2011-06-20 21:01 ` [PATCH] power: " Wolfram Sang
[not found] ` <1308603674-19264-3-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-21 8:54 ` Jean Delvare
[not found] ` <20110621105456.05839025-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-07-08 9:15 ` Wolfram Sang
[not found] ` <20110708091556.GE2048-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-07-08 9:28 ` Anton Vorontsov
2011-07-08 13:10 ` Anton Vorontsov
[not found] ` <20110708131049.GD29056-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2011-07-08 13:40 ` Wolfram Sang
2011-06-21 8:55 ` [PATCH] input/keyboard: " Jean Delvare
2011-06-21 10:40 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2011-08-25 10:48 [PATCH] leds: " Wolfram Sang
[not found] ` <1314269314-16324-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-30 12:44 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308603674-19264-2-git-send-email-w.sang@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).