From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: [PATCH] power: Remove obsolete cleanup for clientdata Date: Mon, 20 Jun 2011 23:01:14 +0200 Message-ID: <1308603674-19264-3-git-send-email-w.sang@pengutronix.de> References: <1308603674-19264-1-git-send-email-w.sang@pengutronix.de> Return-path: In-Reply-To: <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Wolfram Sang , MyungJoo Ham , Anton Vorontsov , Kyungmin Park List-Id: linux-i2c@vger.kernel.org A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang Cc: MyungJoo Ham Cc: Anton Vorontsov Cc: Kyungmin Park --- This is more a cleanup than a bugfix. Still, would be happy to have this obsolete programming style largely removed in 3.0 if possible. drivers/power/max17042_battery.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c index c5c8805..09f7496 100644 --- a/drivers/power/max17042_battery.c +++ b/drivers/power/max17042_battery.c @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client, ret = power_supply_register(&client->dev, &chip->battery); if (ret) { dev_err(&client->dev, "failed: power supply register\n"); - i2c_set_clientdata(client, NULL); kfree(chip); return ret; } @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client) struct max17042_chip *chip = i2c_get_clientdata(client); power_supply_unregister(&chip->battery); - i2c_set_clientdata(client, NULL); kfree(chip); return 0; } -- 1.7.2.5