[PATCH] dt: add empty of_get_property for non-dt

[PATCH] dt: add empty of_get_property for non-dt

[Stephen Warren]

The patch adds empty function of_get_property for non-dt build, so that
drivers migrating to dt can save some '#ifdef CONFIG_OF'.

This also fixes the current Tegra compile problem in linux-next.

Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 include/linux/of.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/include/linux/of.h b/include/linux/of.h
index 0085bb0..9180dc5 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -256,6 +256,13 @@ static inline int of_property_read_string(struct device_node *np,
 	return -ENOSYS;
 }
 
+static inline const void *of_get_property(const struct device_node *node,
+				const char *name,
+				int *lenp)
+{
+	return NULL;
+}
+
 #endif /* CONFIG_OF */
 
 static inline int of_property_read_u32(const struct device_node *np,
-- 
1.7.0.4

Re: [PATCH] dt: add empty of_get_property for non-dt

[Rob Herring]

On 08/05/2011 05:50 PM, Stephen Warren wrote:
> The patch adds empty function of_get_property for non-dt build, so that
> drivers migrating to dt can save some '#ifdef CONFIG_OF'.
> 
> This also fixes the current Tegra compile problem in linux-next.
> 
You could just use of_property_read_u32 in the driver. It already has
empty version and will simplify the driver code some.

Rob

> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  include/linux/of.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 0085bb0..9180dc5 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -256,6 +256,13 @@ static inline int of_property_read_string(struct device_node *np,
>  	return -ENOSYS;
>  }
>  
> +static inline const void *of_get_property(const struct device_node *node,
> +				const char *name,
> +				int *lenp)
> +{
> +	return NULL;
> +}
> +
>  #endif /* CONFIG_OF */
>  
>  static inline int of_property_read_u32(const struct device_node *np,

RE: [PATCH] dt: add empty of_get_property for non-dt

[Stephen Warren]

Rob Herring wrote at Sunday, August 07, 2011 8:38 AM:
> On 08/05/2011 05:50 PM, Stephen Warren wrote:
> > The patch adds empty function of_get_property for non-dt build, so that
> > drivers migrating to dt can save some '#ifdef CONFIG_OF'.
> >
> > This also fixes the current Tegra compile problem in linux-next.
>
> You could just use of_property_read_u32 in the driver. It already has
> empty version and will simplify the driver code some.

Yes, that would also work.

Grant, Ben, do you have a preference for which option to choose?

Thanks.

> > diff --git a/include/linux/of.h b/include/linux/of.h
...
> > +static inline const void *of_get_property(const struct device_node *node,
> > +				const char *name,
> > +				int *lenp)
> > +{
> > +	return NULL;
> > +}
> > +

-- 
nvpublic

Re: [PATCH] dt: add empty of_get_property for non-dt

[Grant Likely]

On Fri, Aug 05, 2011 at 04:50:30PM -0600, Stephen Warren wrote:
> The patch adds empty function of_get_property for non-dt build, so that
> drivers migrating to dt can save some '#ifdef CONFIG_OF'.
> 
> This also fixes the current Tegra compile problem in linux-next.
> 
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  include/linux/of.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)

Merged, thanks.

g.

> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 0085bb0..9180dc5 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -256,6 +256,13 @@ static inline int of_property_read_string(struct device_node *np,
>  	return -ENOSYS;
>  }
>  
> +static inline const void *of_get_property(const struct device_node *node,
> +				const char *name,
> +				int *lenp)
> +{
> +	return NULL;
> +}
> +
>  #endif /* CONFIG_OF */
>  
>  static inline int of_property_read_u32(const struct device_node *np,
> -- 
> 1.7.0.4
>