From: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Tabi Timur-B04825
<B04825-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Tang Yuantian-B29983
<B29983-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH] i2c/busses: (mpc) Add support for SMBUS_READ_BLOCK_DATA
Date: Tue, 15 Nov 2011 13:14:40 -0800 [thread overview]
Message-ID: <1321391680.2309.374.camel@groeck-laptop> (raw)
In-Reply-To: <20111115210528.0f9a0948-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On Tue, 2011-11-15 at 15:05 -0500, Jean Delvare wrote:
> On Tue, 15 Nov 2011 11:14:47 -0800, Guenter Roeck wrote:
> > On Tue, 2011-11-15 at 14:02 -0500, Tabi Timur-B04825 wrote:
> > > I think it's very important to keep the order as-is, if at all
> > > possible. This driver is very old and the hardware is used on all of
> > > our SOCs, dating back several years. It would be a nightmare to test
> > > it all over again.
> >
> > I'll see if I can work around that. 1-byte block reads may be tricky,
> > though, but maybe I can get that working as well.
>
> IMHO it's OK if 1-byte blocks are not supported. In practice the length
> of blocks seems to be known in advance and it's never 1. We can revisit
> if this is ever needed in practice for this specific bus driver.
>
I think I have a workaround for that condition. The workaround will only
apply if the length is 1, so the risk associated with it is low. I'll
test it and let you know if it works.
Guenter
next prev parent reply other threads:[~2011-11-15 21:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 6:27 [PATCH] i2c/busses: (mpc) Add support for SMBUS_READ_BLOCK_DATA Guenter Roeck
[not found] ` <1321338462-6138-1-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-11-15 8:54 ` Jean Delvare
[not found] ` <20111115095445.3d34e99e-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-11-15 16:29 ` Guenter Roeck
2011-11-15 19:02 ` Tabi Timur-B04825
[not found] ` <CAOZdJXVq=0pbrPM_-+Kjf3NhON8oN3Me64R6c9qBiAEFuRsDOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-15 19:14 ` Guenter Roeck
2011-11-15 20:05 ` Jean Delvare
[not found] ` <20111115210528.0f9a0948-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-11-15 21:14 ` Guenter Roeck [this message]
[not found] ` <CAOZdJXUPO5PyMkAw-2EPvy_qSUuqsgUA7Gr8mKUX7HyShoXk3g@mail.gmail.com>
[not found] ` <E6AF40B3BFC8A9428EACB47497F0F4B62DC687@039-SN1MPN1-002.039d.mgd.msft.net>
[not found] ` <ECEE0D23-8F53-402C-A97F-4DB0F0E9C79B@freescale.com>
[not found] ` <ECEE0D23-8F53-402C-A97F-4DB0F0E9C79B-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-11-16 17:28 ` York Sun
2011-11-16 17:36 ` Guenter Roeck
2011-11-16 17:55 ` York Sun
2011-11-16 18:09 ` Guenter Roeck
2011-11-16 18:09 ` Jean Delvare
2011-11-16 18:20 ` York Sun
2011-11-16 18:51 ` Guenter Roeck
2011-11-16 18:56 ` Timur Tabi
2011-11-16 18:58 ` sun york-R58495
2011-11-16 19:10 ` Jean Delvare
[not found] ` <20111116201048.4b7877dd-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-11-16 19:15 ` York Sun
2011-11-16 19:18 ` Jean Delvare
2011-11-16 19:24 ` York Sun
2011-11-17 18:18 ` Guenter Roeck
2011-11-17 19:23 ` York Sun
2011-11-18 3:15 ` Tang Yuantian-B29983
[not found] ` <20111116201847.6b11dc7f-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-12-01 7:06 ` Tang Yuantian-B29983
2011-12-07 2:52 ` Tang Yuantian-B29983
[not found] ` <3C06C26914DACA4BB3A368F78CA0B3A7134583-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-12-07 3:20 ` Guenter Roeck
2011-12-07 5:25 ` Tang Yuantian-B29983
[not found] ` <3C06C26914DACA4BB3A368F78CA0B3A71345F2-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-12-07 7:29 ` Jean Delvare
[not found] ` <20111207082924.2f88bd5d-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-02-23 6:57 ` Huang Changming-R66093
2011-11-16 17:38 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2011-12-12 4:10 Yuantian.tang-KZfg59tc24xl57MIdRCFDg
[not found] ` <1323663010-32223-1-git-send-email-Yuantian.tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-12-12 9:28 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321391680.2309.374.camel@groeck-laptop \
--to=guenter.roeck-izefyvvap7pwk0htik3j/w@public.gmane.org \
--cc=B04825-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=B29983-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).