From: Alok Chauhan <alokc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org,
omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org,
ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org
Cc: alokc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2] i2c: tegra: Add delay before reset the controller
Date: Mon, 2 Apr 2012 11:23:02 +0530 [thread overview]
Message-ID: <1333345982-16595-1-git-send-email-alokc@nvidia.com> (raw)
NACK interrupt generated before I2C controller generates
the STOP condition on bus. In Software, because of this
reset of controller is happening before I2C controller could
complete STOP condition. So wait for some time before resetting
the controller so that STOP condition has delivered properly on bus.
Added delay of 2 clock period before reset the
controller in case of NACK error.
Signed-off-by: Alok Chauhan <alokc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Added the more descriptive commit message about issue in case
of NACK error condition. Changed the comment in code also
drivers/i2c/busses/i2c-tegra.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e978635..dfb850a8 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -516,6 +516,14 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
if (likely(i2c_dev->msg_err == I2C_ERR_NONE))
return 0;
+ /*
+ * NACK interrupt generated before I2C controller generates the STOP
+ * condition on bus. So wait for some time before reset the controller
+ * so that STOP condition has delivered properly on bus.
+ */
+ if (i2c_dev->msg_err == I2C_ERR_NO_ACK)
+ udelay(DIV_ROUND_UP(2 * 1000000, i2c_dev->bus_clk_rate));
+
tegra_i2c_init(i2c_dev);
if (i2c_dev->msg_err == I2C_ERR_NO_ACK) {
if (msg->flags & I2C_M_IGNORE_NAK)
--
1.7.4.1
next reply other threads:[~2012-04-02 5:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 5:53 Alok Chauhan [this message]
[not found] ` <1333345982-16595-1-git-send-email-alokc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-02 5:59 ` [PATCH v2] i2c: tegra: Add delay before reset the controller Alok Chauhan
[not found] ` <7A0BFCFE3DA5CD47B0FB7984326F201A136BDCC35E-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-04-02 10:19 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cuN+qAjDsBNp5Sq_Xs9KGcOQJ+PwjSVW-F0QczxMpWZRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-02 12:06 ` Alok Chauhan
2012-04-02 19:58 ` Stephen Warren
[not found] ` <4F7A0500.3060305-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-13 22:51 ` Stephen Warren
2012-04-18 14:27 ` Wolfram Sang
2012-04-18 20:02 ` Stephen Warren
[not found] ` <4F8F1DBD.8000009-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-18 20:20 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2011-12-26 11:14 Alok Chauhan
[not found] ` <1324898081-10308-1-git-send-email-alokc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-01-06 16:18 ` Ben Dooks
2012-01-10 4:12 ` Alok Chauhan
[not found] ` <7A0BFCFE3DA5CD47B0FB7984326F201A134F2CD4F1-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-02-10 9:20 ` Alok Chauhan
2012-02-10 9:35 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cs+myCvph7OXvCDTG7y48oNTfRtjsDzQaKiEXzjdu3pzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-14 5:49 ` Alok Chauhan
[not found] ` <7A0BFCFE3DA5CD47B0FB7984326F201A13689D386F-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-03-08 6:29 ` Alok Chauhan
[not found] ` <7A0BFCFE3DA5CD47B0FB7984326F201A136B886672-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-03-08 16:30 ` Stephen Warren
[not found] ` <4F58DEB8.9060103-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-26 21:09 ` Dylan Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333345982-16595-1-git-send-email-alokc@nvidia.com \
--to=alokc-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).