linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: arm@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	w.sang@pengutronix.de, srinivas.bakki@nxp.com,
	kevin.wells@nxp.com, gregkh@linuxfoundation.org,
	netdev@vger.kernel.org, rtc-linux@googlegroups.com,
	a.zummo@towertech.it, linux-watchdog@vger.kernel.org,
	wim@iguana.be, jonsmirl@gmail.com
Cc: Roland Stigge <stigge@antcom.de>, stable@vger.kernel.org
Subject: [PATCH v3 5/8] i2c-pnx.c: Fix suspend
Date: Wed,  4 Apr 2012 10:34:37 +0200	[thread overview]
Message-ID: <1333528480-17134-6-git-send-email-stigge@antcom.de> (raw)
In-Reply-To: <1333528480-17134-1-git-send-email-stigge@antcom.de>

In the driver's suspend function, clk_enable() was used instead of
clk_disable(). This is corrected with this patch.

Signed-off-by: Roland Stigge <stigge@antcom.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
CC: stable@vger.kernel.org

---

 Applies to v3.4-rc1

 drivers/i2c/busses/i2c-pnx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-2.6.orig/drivers/i2c/busses/i2c-pnx.c
+++ linux-2.6/drivers/i2c/busses/i2c-pnx.c
@@ -546,8 +546,7 @@ static int i2c_pnx_controller_suspend(st
 {
 	struct i2c_pnx_algo_data *alg_data = platform_get_drvdata(pdev);
 
-	/* FIXME: shouldn't this be clk_disable? */
-	clk_enable(alg_data->clk);
+	clk_disable(alg_data->clk);
 
 	return 0;
 }

  parent reply	other threads:[~2012-04-04  8:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04  8:34 [PATCH v3 0/8] arm: lpc32xx: Device tree support Roland Stigge
2012-04-04  8:34 ` [PATCH v3 1/8] iio: Add device tree support to LPC32xx ADC Roland Stigge
2012-04-04  8:34 ` [PATCH v3 2/8] rtc: Add device tree support for LPC32xx Roland Stigge
2012-04-04  8:34 ` [PATCH v3 3/8] net: Add device tree support to LPC32xx Roland Stigge
2012-04-04  8:39   ` David Miller
2012-04-04  8:34 ` [PATCH v3 4/8] wdt: Device tree support for pnx4008-wdt Roland Stigge
2012-04-04  8:34 ` Roland Stigge [this message]
     [not found]   ` <1333528480-17134-6-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-04-18 17:57     ` [PATCH v3 5/8] i2c-pnx.c: Fix suspend Wolfram Sang
2012-04-04  8:34 ` [PATCH v3 6/8] i2c-pnx.c: Use resources in platforms Roland Stigge
     [not found]   ` <1333528480-17134-7-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-04-18 18:03     ` Wolfram Sang
2012-04-04  8:34 ` [PATCH v3 7/8] i2c-pnx.c: Remove duplicated i2c.h Roland Stigge
     [not found]   ` <1333528480-17134-8-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-04-18 18:04     ` Wolfram Sang
2012-04-04  8:34 ` [PATCH v3 8/8] i2c: Add device tree support to i2c-pnx.c Roland Stigge
     [not found]   ` <1333528480-17134-9-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
2012-04-18 18:09     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333528480-17134-6-git-send-email-stigge@antcom.de \
    --to=stigge@antcom.de \
    --cc=a.zummo@towertech.it \
    --cc=arm@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonsmirl@gmail.com \
    --cc=kevin.wells@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=srinivas.bakki@nxp.com \
    --cc=stable@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).