From: David Daney <ddaney.cavm@gmail.com>
To: Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.org,
"Jean Delvare (PC drivers core)" <khali@linux-fr.org>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
"Wolfram Sang (embedded platforms)" <w.sang@pengutronix.de>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Guenter Roeck <guenter.roeck@ericsson.com>,
linux-i2c@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>
Cc: linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v3 2/2] i2c/of: Automatically populate i2c mux busses from device tree data.
Date: Thu, 12 Apr 2012 14:14:23 -0700 [thread overview]
Message-ID: <1334265263-13549-3-git-send-email-ddaney.cavm@gmail.com> (raw)
In-Reply-To: <1334265263-13549-1-git-send-email-ddaney.cavm@gmail.com>
From: David Daney <david.daney@cavium.com>
For 'normal' i2c bus drivers, we can call of_i2c_register_devices()
and have the device tree framework automatically populate the bus with
the devices specified in the device tree.
This patch adds a common code to the i2c mux framework to have the mux
sub-busses be populated by the of_i2c_register_devices() too. If the
mux device has an of_node, we populate the sub-bus' of_node so that
the subsequent call to of_i2c_register_devices() will find the
corresponding devices.
It seemed better to put this logic in i2c_add_mux_adapter() rather
than the individual mux drivers, as they will all probably want to do
the same thing.
Signed-off-by: David Daney <david.daney@cavium.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
---
Documentation/devicetree/bindings/i2c/mux.txt | 60 +++++++++++++++++++++++++
drivers/i2c/i2c-mux.c | 24 ++++++++++
2 files changed, 84 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/i2c/mux.txt
diff --git a/Documentation/devicetree/bindings/i2c/mux.txt b/Documentation/devicetree/bindings/i2c/mux.txt
new file mode 100644
index 0000000..af84cce
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/mux.txt
@@ -0,0 +1,60 @@
+Common i2c bus multiplexer/switch properties.
+
+An i2c bus multiplexer/switch will have several child busses that are
+numbered uniquely in a device dependent manner. The nodes for an i2c bus
+multiplexer/switch will have one child node for each child
+bus.
+
+Required properties:
+- #address-cells = <1>;
+- #size-cells = <0>;
+
+Required properties for child nodes:
+- #address-cells = <1>;
+- #size-cells = <0>;
+- reg : The sub-bus number.
+
+Optional properties for child nodes:
+- Other properties specific to the multiplexer/switch hardware.
+- Child nodes conforming to i2c bus binding
+
+
+Example :
+
+ /*
+ An NXP pca9548 8 channel I2C multiplexer at address 0x70
+ with two NXP pca8574 GPIO expanders attached, one each to
+ ports 3 and 4.
+ */
+
+ mux@70 {
+ compatible = "nxp,pca9548";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+
+ gpio1: gpio@38 {
+ compatible = "nxp,pca8574";
+ reg = <0x38>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+ };
+ i2c@4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <4>;
+
+ gpio2: gpio@38 {
+ compatible = "nxp,pca8574";
+ reg = <0x38>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+ };
+ };
diff --git a/drivers/i2c/i2c-mux.c b/drivers/i2c/i2c-mux.c
index 26ab31d..609794b 100644
--- a/drivers/i2c/i2c-mux.c
+++ b/drivers/i2c/i2c-mux.c
@@ -24,6 +24,8 @@
#include <linux/slab.h>
#include <linux/i2c.h>
#include <linux/i2c-mux.h>
+#include <linux/of.h>
+#include <linux/of_i2c.h>
/* multiplexer per channel data */
struct i2c_mux_priv {
@@ -125,6 +127,26 @@ struct i2c_adapter *i2c_add_mux_adapter(struct i2c_adapter *parent,
priv->adap.algo_data = priv;
priv->adap.dev.parent = &parent->dev;
+ /*
+ * Try to get populate the mux adapter's of_node, expands to
+ * nothing if !CONFIG_OF.
+ */
+ if (mux_dev->of_node) {
+ struct device_node *child;
+ u32 reg;
+ int ret;
+
+ for_each_child_of_node(mux_dev->of_node, child) {
+ ret = of_property_read_u32(child, "reg", ®);
+ if (ret)
+ continue;
+ if (chan_id == reg) {
+ priv->adap.dev.of_node = child;
+ break;
+ }
+ }
+ }
+
if (force_nr) {
priv->adap.nr = force_nr;
ret = i2c_add_numbered_adapter(&priv->adap);
@@ -142,6 +164,8 @@ struct i2c_adapter *i2c_add_mux_adapter(struct i2c_adapter *parent,
dev_info(&parent->dev, "Added multiplexed i2c bus %d\n",
i2c_adapter_id(&priv->adap));
+ of_i2c_register_devices(&priv->adap);
+
return &priv->adap;
}
EXPORT_SYMBOL_GPL(i2c_add_mux_adapter);
--
1.7.2.3
next prev parent reply other threads:[~2012-04-12 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 21:14 [PATCH v3 0/2] i2c/of: Populate multiplexed i2c busses from the device tree David Daney
2012-04-12 21:14 ` [PATCH v3 1/2] i2c: Add a struct device * parameter to i2c_add_mux_adapter() David Daney
2012-04-12 21:14 ` David Daney [this message]
[not found] ` <1334265263-13549-3-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-04-22 16:20 ` [PATCH v3 2/2] i2c/of: Automatically populate i2c mux busses from device tree data Wolfram Sang
[not found] ` <20120422162008.GA4201-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-23 16:48 ` David Daney
[not found] ` <4F9587E8.1050702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-04-23 16:58 ` Wolfram Sang
[not found] ` <20120423165847.GF27321-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-04-23 17:04 ` David Daney
2012-04-23 17:11 ` Stephen Warren
2012-04-13 11:09 ` [PATCH v3 0/2] i2c/of: Populate multiplexed i2c busses from the device tree Lars-Peter Clausen
[not found] ` <4F880960.8010803-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2012-04-23 17:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334265263-13549-3-git-send-email-ddaney.cavm@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=ben-linux@fluff.org \
--cc=david.daney@cavium.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.korsgaard@barco.com \
--cc=rob.herring@calxeda.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).