[PATCH] i2c: muxes: rename first set of drivers to a standard pattern

[PATCH] i2c: muxes: rename first set of drivers to a standard pattern

[Wolfram Sang]

Apply a naming pattern like in the rest of the subsystem to a first set
of mux drivers. Those drivers are the low-hanging fruit; we want to pick
them to motivate upcoming drivers to follow the new pattern. The missing
GPIO driver will be converted in a later patch.

Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Acked-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org> (pca9541)
Cc: Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
---
 drivers/i2c/muxes/Kconfig                          |    4 ++--
 drivers/i2c/muxes/Makefile                         |    4 ++--
 drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} |    0
 drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} |    0
 4 files changed, 4 insertions(+), 4 deletions(-)
 rename drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} (100%)
 rename drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} (100%)

diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig
index 90b7a01..e14a420 100644
--- a/drivers/i2c/muxes/Kconfig
+++ b/drivers/i2c/muxes/Kconfig
@@ -25,7 +25,7 @@ config I2C_MUX_PCA9541
 	  I2C Master Selector.
 
 	  This driver can also be built as a module.  If so, the module
-	  will be called pca9541.
+	  will be called i2c-mux-pca9541.
 
 config I2C_MUX_PCA954x
 	tristate "Philips PCA954x I2C Mux/switches"
@@ -35,6 +35,6 @@ config I2C_MUX_PCA954x
 	  I2C mux/switch devices.
 
 	  This driver can also be built as a module.  If so, the module
-	  will be called pca954x.
+	  will be called i2c-mux-pca954x.
 
 endmenu
diff --git a/drivers/i2c/muxes/Makefile b/drivers/i2c/muxes/Makefile
index 4640436..0868335 100644
--- a/drivers/i2c/muxes/Makefile
+++ b/drivers/i2c/muxes/Makefile
@@ -2,7 +2,7 @@
 # Makefile for multiplexer I2C chip drivers.
 
 obj-$(CONFIG_I2C_MUX_GPIO)	+= gpio-i2cmux.o
-obj-$(CONFIG_I2C_MUX_PCA9541)	+= pca9541.o
-obj-$(CONFIG_I2C_MUX_PCA954x)	+= pca954x.o
+obj-$(CONFIG_I2C_MUX_PCA9541)	+= i2c-mux-pca9541.o
+obj-$(CONFIG_I2C_MUX_PCA954x)	+= i2c-mux-pca954x.o
 
 ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG
diff --git a/drivers/i2c/muxes/pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
similarity index 100%
rename from drivers/i2c/muxes/pca9541.c
rename to drivers/i2c/muxes/i2c-mux-pca9541.c
diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
similarity index 100%
rename from drivers/i2c/muxes/pca954x.c
rename to drivers/i2c/muxes/i2c-mux-pca954x.c
-- 
1.7.10

Re: [PATCH] i2c: muxes: rename first set of drivers to a standard pattern

[Jean Delvare]

On Wed, 25 Apr 2012 22:43:56 +0200, Wolfram Sang wrote:
> Apply a naming pattern like in the rest of the subsystem to a first set
> of mux drivers. Those drivers are the low-hanging fruit; we want to pick
> them to motivate upcoming drivers to follow the new pattern. The missing
> GPIO driver will be converted in a later patch.
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Acked-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org> (pca9541)
> Cc: Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> ---
>  drivers/i2c/muxes/Kconfig                          |    4 ++--
>  drivers/i2c/muxes/Makefile                         |    4 ++--
>  drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} |    0
>  drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} |    0
>  4 files changed, 4 insertions(+), 4 deletions(-)
>  rename drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} (100%)
>  rename drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} (100%)

Good idea.

Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

(I can pick this in my tree if you want, just let me know.)

Now that you made i2c mux non-experimental, I think it would be great
to solve the gpio mux case quickly. Renaming drivers, header files and
public structures is better done early. I'll give it a try.

-- 
Jean Delvare

Re: [PATCH] i2c: muxes: rename first set of drivers to a standard pattern

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

On Fri, Apr 27, 2012 at 09:59:46AM +0200, Jean Delvare wrote:
> On Wed, 25 Apr 2012 22:43:56 +0200, Wolfram Sang wrote:
> > Apply a naming pattern like in the rest of the subsystem to a first set
> > of mux drivers. Those drivers are the low-hanging fruit; we want to pick
> > them to motivate upcoming drivers to follow the new pattern. The missing
> > GPIO driver will be converted in a later patch.
> 
> Good idea.

Thanks.

> Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> 
> (I can pick this in my tree if you want, just let me know.)

Since I do carry some mux-patches already, might be easier if I keep it.

> Now that you made i2c mux non-experimental, I think it would be great
> to solve the gpio mux case quickly. Renaming drivers, header files and
> public structures is better done early. I'll give it a try.

Cool. I intended to ping Peter after my patch, but forgot :/

Will fix the MAINTAINER issue you just mentioned.

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] i2c: muxes: rename first set of drivers to a standard pattern

[Jean Delvare]

Hi again Wolfram,

On Wed, 25 Apr 2012 22:43:56 +0200, Wolfram Sang wrote:
> Apply a naming pattern like in the rest of the subsystem to a first set
> of mux drivers. Those drivers are the low-hanging fruit; we want to pick
> them to motivate upcoming drivers to follow the new pattern. The missing
> GPIO driver will be converted in a later patch.
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Acked-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org> (pca9541)
> Cc: Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> ---
>  drivers/i2c/muxes/Kconfig                          |    4 ++--
>  drivers/i2c/muxes/Makefile                         |    4 ++--
>  drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} |    0
>  drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} |    0
>  4 files changed, 4 insertions(+), 4 deletions(-)
>  rename drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} (100%)
>  rename drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} (100%)

Oh, BTW, you'll have to update the "PCA9541 I2C BUS MASTER SELECTOR
DRIVER" entry in MAINTAINERS too.

-- 
Jean Delvare