From: Felipe Balbi <balbi@ti.com>
To: ben-linux@fluff.org
Cc: Tony Lindgren <tony@atomide.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>,
w.sang@pengutronix.de, linux-i2c@vger.kernel.org,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 02/17] i2c: omap: decrease indentation level on data handling
Date: Thu, 14 Jun 2012 13:20:35 +0300 [thread overview]
Message-ID: <1339669250-9183-3-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1339669250-9183-1-git-send-email-balbi@ti.com>
trivial patch, no functional changes.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/i2c/busses/i2c-omap.c | 63 ++++++++++++++++++++---------------------
1 file changed, 31 insertions(+), 32 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 9b532cd..39d5583 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -856,22 +856,7 @@ complete:
>> 8) & 0x3F;
}
while (num_bytes--) {
- w = omap_i2c_read_reg(dev, OMAP_I2C_DATA_REG);
- if (dev->buf_len) {
- *dev->buf++ = w;
- dev->buf_len--;
- /*
- * Data reg in 2430, omap3 and
- * omap4 is 8 bit wide
- */
- if (dev->flags &
- OMAP_I2C_FLAG_16BIT_DATA_REG) {
- if (dev->buf_len) {
- *dev->buf++ = w >> 8;
- dev->buf_len--;
- }
- }
- } else {
+ if (!dev->buf_len) {
if (stat & OMAP_I2C_STAT_RRDY)
dev_err(dev->dev,
"RRDY IRQ while no data"
@@ -882,6 +867,21 @@ complete:
" requested\n");
break;
}
+
+ w = omap_i2c_read_reg(dev, OMAP_I2C_DATA_REG);
+ *dev->buf++ = w;
+ dev->buf_len--;
+ /*
+ * Data reg in 2430, omap3 and
+ * omap4 is 8 bit wide
+ */
+ if (dev->flags &
+ OMAP_I2C_FLAG_16BIT_DATA_REG) {
+ if (dev->buf_len) {
+ *dev->buf++ = w >> 8;
+ dev->buf_len--;
+ }
+ }
}
omap_i2c_ack_stat(dev,
stat & (OMAP_I2C_STAT_RRDY | OMAP_I2C_STAT_RDR));
@@ -898,22 +898,7 @@ complete:
& 0x3F;
}
while (num_bytes--) {
- w = 0;
- if (dev->buf_len) {
- w = *dev->buf++;
- dev->buf_len--;
- /*
- * Data reg in 2430, omap3 and
- * omap4 is 8 bit wide
- */
- if (dev->flags &
- OMAP_I2C_FLAG_16BIT_DATA_REG) {
- if (dev->buf_len) {
- w |= *dev->buf++ << 8;
- dev->buf_len--;
- }
- }
- } else {
+ if (!dev->buf_len) {
if (stat & OMAP_I2C_STAT_XRDY)
dev_err(dev->dev,
"XRDY IRQ while no "
@@ -925,6 +910,20 @@ complete:
break;
}
+ w = *dev->buf++;
+ dev->buf_len--;
+ /*
+ * Data reg in 2430, omap3 and
+ * omap4 is 8 bit wide
+ */
+ if (dev->flags &
+ OMAP_I2C_FLAG_16BIT_DATA_REG) {
+ if (dev->buf_len) {
+ w |= *dev->buf++ << 8;
+ dev->buf_len--;
+ }
+ }
+
if ((dev->errata & I2C_OMAP3_1P153) &&
errata_omap3_1p153(dev, &stat, &err))
goto complete;
--
1.7.10.4
next prev parent reply other threads:[~2012-06-14 10:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 10:20 [PATCH 00/17] Big OMAP I2C Cleanup Felipe Balbi
2012-06-14 10:20 ` [PATCH 01/17] i2c: omap: simplify num_bytes handling Felipe Balbi
[not found] ` <1339669250-9183-2-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-06-14 10:33 ` Shilimkar, Santosh
2012-06-14 10:20 ` Felipe Balbi [this message]
[not found] ` <1339669250-9183-3-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-06-14 10:41 ` [PATCH 02/17] i2c: omap: decrease indentation level on data handling Shilimkar, Santosh
2012-06-14 10:40 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 03/17] i2c: omap: add blank lines Felipe Balbi
[not found] ` <1339669250-9183-4-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-06-14 10:43 ` Shilimkar, Santosh
[not found] ` <1339669250-9183-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-06-14 10:20 ` [PATCH 04/17] i2c: omap: simplify omap_i2c_ack_stat() Felipe Balbi
[not found] ` <1339669250-9183-5-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-06-14 10:45 ` Shilimkar, Santosh
2012-06-14 11:13 ` Russell King - ARM Linux
2012-06-14 11:45 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 06/17] i2c: omap: improve 1p153 errata handling Felipe Balbi
2012-06-14 11:01 ` Shilimkar, Santosh
2012-06-14 11:17 ` Russell King - ARM Linux
[not found] ` <20120614111746.GB31187-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-06-14 11:48 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 08/17] i2c: omap: switch over to do {} while loop Felipe Balbi
[not found] ` <1339669250-9183-9-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-06-14 11:03 ` Shilimkar, Santosh
2012-06-14 11:05 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 13/17] i2c: omap: bus: add a receiver flag Felipe Balbi
2012-06-14 10:20 ` [PATCH 16/17] i2c: omap: simplify IRQ exit path Felipe Balbi
2012-06-14 11:23 ` [PATCH 00/17] Big OMAP I2C Cleanup Shilimkar, Santosh
2012-06-14 10:20 ` [PATCH 05/17] i2c: omap: split out [XR]DR and [XR]RDY Felipe Balbi
2012-06-14 10:20 ` [PATCH 07/17] i2c: omap: re-factor receive/transmit data loop Felipe Balbi
2012-06-14 10:20 ` [PATCH 09/17] i2c: omap: ack IRQ in parts Felipe Balbi
2012-06-14 11:11 ` Shilimkar, Santosh
2012-06-14 11:46 ` Felipe Balbi
2012-06-14 11:20 ` Russell King - ARM Linux
[not found] ` <20120614112017.GC31187-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-06-14 11:47 ` Felipe Balbi
2012-06-14 10:20 ` [PATCH 10/17] i2c: omap: get rid of the "complete" label Felipe Balbi
2012-06-14 10:20 ` [PATCH 11/17] i2c: omap: switch to devm_* API Felipe Balbi
2012-06-14 10:20 ` [PATCH 12/17] i2c: omap: switch to platform_get_irq() Felipe Balbi
2012-06-14 10:20 ` [PATCH 14/17] i2c: omap: simplify errata check Felipe Balbi
2012-06-14 10:20 ` [PATCH 15/17] i2c: omap: always return IRQ_HANDLED Felipe Balbi
[not found] ` <1339669250-9183-16-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-06-14 11:18 ` Shilimkar, Santosh
2012-06-14 11:23 ` Russell King - ARM Linux
[not found] ` <20120614112323.GD31187-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-06-14 11:25 ` Shilimkar, Santosh
2012-06-14 10:20 ` [PATCH 17/17] i2c: omap: resize fifos before each message Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339669250-9183-3-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).