From: Daniel Kurtz <djkurtz@chromium.org>
To: Jean Delvare <khali@linux-fr.org>,
Ben Dooks <ben-linux@fluff.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Seth Heasley <seth.heasley@intel.com>
Cc: Olof Johansson <olof@lixom.net>,
Benson Leung <bleung@chromium.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Kurtz <djkurtz@chromium.org>
Subject: [PATCH] i2c-i801: Clear only status bits in HST_STS after waiting for INTR
Date: Thu, 28 Jun 2012 16:59:30 +0800 [thread overview]
Message-ID: <1340873970-19226-1-git-send-email-djkurtz@chromium.org> (raw)
Writing back the whole status register could clear unwanted bits.
In particular, it could clear the "INUSE_STS" bit, which is a
'hardware semaphore', that might be useful to use some day.
To prepare for this, let's ban writing back the whole status to register
HST_STS, of which this is the only instance.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Reported-by: Jean Delvare <khali@linux-fr.org>
---
drivers/i2c/busses/i2c-i801.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index ae2945a..7443990 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -301,7 +301,7 @@ static void i801_wait_hwpec(struct i801_priv *priv)
if (timeout > MAX_RETRIES)
dev_dbg(&priv->pci_dev->dev, "PEC Timeout!\n");
- outb_p(status, SMBHSTSTS(priv));
+ outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv));
}
static int i801_block_transaction_by_block(struct i801_priv *priv,
--
1.7.7.3
next reply other threads:[~2012-06-28 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 8:59 Daniel Kurtz [this message]
[not found] ` <1340873970-19226-1-git-send-email-djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-06-28 12:51 ` [PATCH] i2c-i801: Clear only status bits in HST_STS after waiting for INTR Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340873970-19226-1-git-send-email-djkurtz@chromium.org \
--to=djkurtz@chromium.org \
--cc=ben-linux@fluff.org \
--cc=bleung@chromium.org \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=seth.heasley@intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).