From: "Richard Röjfors" <richard.rojfors-gfIc91nka+FZroRs9YW3xA@public.gmane.org>
To: Jayachandran C
<jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
Cc: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org
Subject: Re: [PATCH 3/4] V4L/DVB: mfd: use reg_shift instead of regstep
Date: Wed, 11 Jul 2012 23:09:40 +0200 [thread overview]
Message-ID: <1342040980.3798.1.camel@rorics.office.pelagicore.net> (raw)
In-Reply-To: <1341900658-7698-4-git-send-email-jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
On Tue, 2012-07-10 at 11:40 +0530, Jayachandran C wrote:
> Update for change in i2c-ocores.h which uses reg_shift to
> specify the register offset shifts instead of regstep.
>
> Signed-off-by: Jayachandran C <jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
Looks good to me.
Acked-by: Richard Röjfors <richard.rojfors-gfIc91nka+FZroRs9YW3xA@public.gmane.org>
> ---
> drivers/mfd/timberdale.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
> index 0ba26fb..a447f4e 100644
> --- a/drivers/mfd/timberdale.c
> +++ b/drivers/mfd/timberdale.c
> @@ -83,7 +83,7 @@ timberdale_xiic_platform_data = {
>
> static __devinitdata struct ocores_i2c_platform_data
> timberdale_ocores_platform_data = {
> - .regstep = 4,
> + .reg_shift = 2,
> .clock_khz = 62500,
> .devices = timberdale_i2c_board_info,
> .num_devices = ARRAY_SIZE(timberdale_i2c_board_info)
next prev parent reply other threads:[~2012-07-11 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 6:10 [PATCH RESEND 0/4] I2C Ocores updates Jayachandran C
[not found] ` <1341900658-7698-1-git-send-email-jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
2012-07-10 6:10 ` [PATCH 1/4] i2c: i2c-ocores - DT bindings and minor fixes Jayachandran C
2012-07-10 6:10 ` [PATCH 2/4] i2c: i2c-ocores: Use reg-shift property Jayachandran C
[not found] ` <1341900658-7698-3-git-send-email-jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
2012-07-12 13:31 ` Wolfram Sang
[not found] ` <20120712133157.GI2194-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-12 14:02 ` Jayachandran C.
2012-07-10 6:10 ` [PATCH 3/4] V4L/DVB: mfd: use reg_shift instead of regstep Jayachandran C
[not found] ` <1341900658-7698-4-git-send-email-jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
2012-07-11 21:09 ` Richard Röjfors [this message]
2012-07-12 13:34 ` Wolfram Sang
2012-07-10 6:10 ` [PATCH 4/4] i2c: i2c-ocores: support for 16bit and 32bit IO Jayachandran C
[not found] ` <1341900658-7698-5-git-send-email-jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
2012-07-12 13:35 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2012-07-13 6:38 [PATCH v2 0/4] I2C Ocores updates Jayachandran C
[not found] ` <1342161543-5838-1-git-send-email-jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
2012-07-13 6:49 ` [PATCH 3/4] V4L/DVB: mfd: use reg_shift instead of regstep Jayachandran C
2012-06-05 15:41 [PATCH 0/4] I2C Ocores updates Jayachandran C
[not found] ` <1338910868-12318-1-git-send-email-jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org>
2012-06-05 15:41 ` [PATCH 3/4] V4L/DVB: mfd: use reg_shift instead of regstep Jayachandran C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342040980.3798.1.camel@rorics.office.pelagicore.net \
--to=richard.rojfors-gfic91nka+fzrors9yw3xa@public.gmane.org \
--cc=jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org \
--cc=jayachandranc-oSioyQM9ZPnuBjGU1YDckgC/G2K4zDHf@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).