* [PATCH 1/2] i2c: imx: Use dev_info to indicate that i2c driver was succesfully registered
@ 2012-08-01 20:38 Fabio Estevam
[not found] ` <1343853495-23479-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2012-08-01 20:38 UTC (permalink / raw)
To: wolfram-z923LK4zBo2bacvFa/9K2g
Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
Fabio Estevam
From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
It is useful information in dmesg to have a message indicating that the i2c
driver was succesfully registered, so promote it to dev_info.
Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
drivers/i2c/busses/i2c-imx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 0722f86..e143629 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -564,7 +564,7 @@ static int __init i2c_imx_probe(struct platform_device *pdev)
resource_size(res), res->start);
dev_dbg(&i2c_imx->adapter.dev, "adapter name: \"%s\"\n",
i2c_imx->adapter.name);
- dev_dbg(&i2c_imx->adapter.dev, "IMX I2C adapter registered\n");
+ dev_info(&i2c_imx->adapter.dev, "IMX I2C adapter registered\n");
return 0; /* Return OK */
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] i2c: imx: Use dev_dbg logging style
[not found] ` <1343853495-23479-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2012-08-01 20:38 ` Fabio Estevam
2012-08-03 14:25 ` [PATCH 1/2] i2c: imx: Use dev_info to indicate that i2c driver was succesfully registered Sascha Hauer
2012-08-18 7:45 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2012-08-01 20:38 UTC (permalink / raw)
To: wolfram-z923LK4zBo2bacvFa/9K2g
Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
Fabio Estevam
From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Use dev_dbg logging style as it is done in other parts of this driver.
Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
drivers/i2c/busses/i2c-imx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index e143629..2e1d5f4 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -272,9 +272,9 @@ static void __init i2c_imx_set_clk(struct imx_i2c_struct *i2c_imx,
/* dev_dbg() can't be used, because adapter is not yet registered */
#ifdef CONFIG_I2C_DEBUG_BUS
- printk(KERN_DEBUG "I2C: <%s> I2C_CLK=%d, REQ DIV=%d\n",
+ dev_dbg(&i2c_imx->adapter.dev, "<%s> I2C_CLK=%d, REQ DIV=%d\n",
__func__, i2c_clk_rate, div);
- printk(KERN_DEBUG "I2C: <%s> IFDR[IC]=0x%x, REAL DIV=%d\n",
+ dev_dbg(&i2c_imx->adapter.dev, "<%s> IFDR[IC]=0x%x, REAL DIV=%d\n",
__func__, i2c_clk_div[i][1], i2c_clk_div[i][0]);
#endif
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] i2c: imx: Use dev_info to indicate that i2c driver was succesfully registered
[not found] ` <1343853495-23479-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-01 20:38 ` [PATCH 2/2] i2c: imx: Use dev_dbg logging style Fabio Estevam
@ 2012-08-03 14:25 ` Sascha Hauer
2012-08-18 7:45 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2012-08-03 14:25 UTC (permalink / raw)
To: Fabio Estevam
Cc: wolfram-z923LK4zBo2bacvFa/9K2g, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
linux-i2c-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam
On Wed, Aug 01, 2012 at 05:38:14PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> It is useful information in dmesg to have a message indicating that the i2c
> driver was succesfully registered, so promote it to dev_info.
>
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Both:
Acked-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Sascha
> ---
> drivers/i2c/busses/i2c-imx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 0722f86..e143629 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -564,7 +564,7 @@ static int __init i2c_imx_probe(struct platform_device *pdev)
> resource_size(res), res->start);
> dev_dbg(&i2c_imx->adapter.dev, "adapter name: \"%s\"\n",
> i2c_imx->adapter.name);
> - dev_dbg(&i2c_imx->adapter.dev, "IMX I2C adapter registered\n");
> + dev_info(&i2c_imx->adapter.dev, "IMX I2C adapter registered\n");
>
> return 0; /* Return OK */
> }
> --
> 1.7.1
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] i2c: imx: Use dev_info to indicate that i2c driver was succesfully registered
[not found] ` <1343853495-23479-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-01 20:38 ` [PATCH 2/2] i2c: imx: Use dev_dbg logging style Fabio Estevam
2012-08-03 14:25 ` [PATCH 1/2] i2c: imx: Use dev_info to indicate that i2c driver was succesfully registered Sascha Hauer
@ 2012-08-18 7:45 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2012-08-18 7:45 UTC (permalink / raw)
To: Fabio Estevam
Cc: wolfram-z923LK4zBo2bacvFa/9K2g, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
linux-i2c-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
On Wed, Aug 01, 2012 at 05:38:14PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> It is useful information in dmesg to have a message indicating that the i2c
> driver was succesfully registered, so promote it to dev_info.
>
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Both applied to -next, thanks!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-18 7:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-01 20:38 [PATCH 1/2] i2c: imx: Use dev_info to indicate that i2c driver was succesfully registered Fabio Estevam
[not found] ` <1343853495-23479-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-01 20:38 ` [PATCH 2/2] i2c: imx: Use dev_dbg logging style Fabio Estevam
2012-08-03 14:25 ` [PATCH 1/2] i2c: imx: Use dev_info to indicate that i2c driver was succesfully registered Sascha Hauer
2012-08-18 7:45 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).