From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Jim Cromie <jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c/scx200_*: replace printks with pr_<level>s
Date: Fri, 14 Sep 2012 22:34:17 -0700 [thread overview]
Message-ID: <1347687257.2072.4.camel@joe2Laptop> (raw)
In-Reply-To: <1347679318-6834-1-git-send-email-jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Fri, 2012-09-14 at 21:21 -0600, Jim Cromie wrote:
> Replace printks with pr_<level>s, add pr_fmt()s to replace NAMEs
Hi Jim.
When you do these, please maximally fill to 80 columns the printk
arguments and coalesce formats without regard to 80 columns.
> diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
> @@ -406,7 +408,7 @@ static __devinit int scx200_acb_probe(struct scx200_acb_iface *iface)
>
> val = inb(ACBCTL1);
> if (val) {
> - pr_debug(NAME ": disabled, but ACBCTL1=0x%02x\n",
> + pr_debug("disabled, but ACBCTL1=0x%02x\n",
> val);
pr_debug("disabled, but ACBCTL1=0x%02x\n", val);
> @@ -417,7 +419,7 @@ static __devinit int scx200_acb_probe(struct scx200_acb_iface *iface)
>
> val = inb(ACBCTL1);
> if ((val & ACBCTL1_NMINTE) != ACBCTL1_NMINTE) {
> - pr_debug(NAME ": enabled, but NMINTE won't be set, "
> + pr_debug("enabled, but NMINTE won't be set, "
> "ACBCTL1=0x%02x\n", val);
pr_debug("enabled, but NMINTE won't be set, ACBCTL1=0x%02x\n",
val);
etc...
prev parent reply other threads:[~2012-09-15 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 3:21 [PATCH] i2c/scx200_*: replace printks with pr_<level>s Jim Cromie
[not found] ` <1347679318-6834-1-git-send-email-jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-15 5:34 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347687257.2072.4.camel@joe2Laptop \
--to=joe-6d6dil74uinbdgjk7y7tuq@public.gmane.org \
--cc=jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).