linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linux OMAP Mailing List
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux ARM Kernel Mailing List
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Subject: [PATCH REBASE 2/6] i2c: omap: also complete() when stat becomes zero
Date: Fri, 14 Dec 2012 18:34:05 +0200	[thread overview]
Message-ID: <1355502849-9289-3-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1355502849-9289-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>

In case we loop on IRQ handler until stat is
finally zero, we would end up in a situation
where all I2C transfers would misteriously
timeout because we were not calling complete()
in that situation.

Fix the issue by moving omap_i2c_complete_cmd()
call inside the 'out' label.

Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
---
 drivers/i2c/busses/i2c-omap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 9a9cf7c..fcecb0b 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1022,9 +1022,8 @@ omap_i2c_isr_thread(int this_irq, void *dev_id)
 		}
 	} while (stat);
 
-	omap_i2c_complete_cmd(dev, err);
-
 out:
+	omap_i2c_complete_cmd(dev, err);
 	spin_unlock_irqrestore(&dev->lock, flags);
 
 	return IRQ_HANDLED;
-- 
1.8.1.rc1.5.g7e0651a

  parent reply	other threads:[~2012-12-14 16:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14 16:34 [PATCH REBASE 0/6] i2c: omap: misc changes Felipe Balbi
2012-12-14 16:34 ` [PATCH REBASE 1/6] i2c: omap: no need to access platform_device Felipe Balbi
2012-12-14 16:34 ` [PATCH REBASE 3/6] i2c: omap: improve 'rev' a little bit Felipe Balbi
     [not found] ` <1355502849-9289-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-12-14 16:34   ` Felipe Balbi [this message]
2012-12-14 16:34   ` [PATCH REBASE 4/6] i2c: omap: in case of VERSION_2 read IRQSTATUS_RAW but write to IRQSTATUS Felipe Balbi
2012-12-14 16:34   ` [PATCH REBASE 5/6] i2c: omap: wait for transfer completion before sending STP bit Felipe Balbi
2013-01-14 19:16   ` [PATCH REBASE 0/6] i2c: omap: misc changes Felipe Balbi
     [not found]     ` <20130114191628.GB9402-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-01-23  9:58       ` Wolfram Sang
2013-01-23 10:23         ` [PATCH 0/6] i2c: deferred STP Felipe Balbi
2013-01-23 10:23           ` [PATCH 2/6] i2c: omap: also complete() when stat becomes zero Felipe Balbi
2013-01-24  9:05             ` Aaro Koskinen
2013-01-24  9:13               ` Felipe Balbi
     [not found]                 ` <20130124091339.GF27304-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-01-24  9:37                   ` Felipe Balbi
2013-01-24  9:56                 ` Aaro Koskinen
2013-01-23 10:23           ` [PATCH 3/6] i2c: omap: improve 'rev' a little bit Felipe Balbi
     [not found]           ` <1358936588-16375-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2013-01-23 10:23             ` [PATCH 1/6] i2c: omap: no need to access platform_device Felipe Balbi
2013-01-23 10:23             ` [PATCH 4/6] i2c: omap: in case of VERSION_2 read IRQSTATUS_RAW but write to IRQSTATUS Felipe Balbi
2013-01-23 10:23             ` [PATCH 5/6] i2c: omap: wait for transfer completion before sending STP bit Felipe Balbi
2013-01-23 20:10               ` Aaro Koskinen
2013-01-24  7:35                 ` Felipe Balbi
2013-01-24  7:42                   ` [PATCH 5/6 v2] " Felipe Balbi
2013-01-23 10:23             ` [PATCH 6/6] i2c: omap: get rid of b_hw flag Felipe Balbi
2013-01-23 20:05             ` [PATCH 0/6] i2c: deferred STP Aaro Koskinen
     [not found]               ` <20130123200540.GE23057-R3WNPi76c83LsdW6vOPryG4HOFkwEHDbMR2xtNvyitY@public.gmane.org>
2013-01-24 16:11                 ` Aaro Koskinen
2012-12-14 16:34 ` [PATCH REBASE 6/6] i2c: omap: get rid of b_hw flag Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355502849-9289-3-git-send-email-balbi@ti.com \
    --to=balbi-l0cymroini0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).