From: Inderpal Singh <inderpal.singh@linaro.org>
To: linux-i2c@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
ben-linux@fluff.org, thomas.abraham@linaro.org,
patches@linaro.org
Subject: [PATCH 1/2] i2c: s3c2410: Initialize i2c->gpios[] with requested gpio lines
Date: Thu, 27 Dec 2012 09:39:43 +0530 [thread overview]
Message-ID: <1356581384-23063-1-git-send-email-inderpal.singh@linaro.org> (raw)
i2c->gpios[] is being used to free_gpios but it's not getting initialized.
Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
---
drivers/i2c/busses/i2c-s3c2410.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index a290d08..f1d1f1e 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -875,6 +875,8 @@ static int s3c24xx_i2c_parse_dt_gpio(struct s3c24xx_i2c *i2c)
dev_err(i2c->dev, "gpio [%d] request failed\n", gpio);
goto free_gpio;
}
+
+ i2c->gpios[idx] = gpio;
}
return 0;
--
1.7.9.5
next reply other threads:[~2012-12-27 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 4:09 Inderpal Singh [this message]
[not found] ` <1356581384-23063-1-git-send-email-inderpal.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-12-27 4:09 ` [PATCH 2/2] i2c: s3c2410: free gpios in suspend function Inderpal Singh
2012-12-27 4:38 ` Inderpal Singh
2012-12-27 4:39 ` [PATCH 1/2] i2c: s3c2410: Initialize i2c->gpios[] with requested gpio lines Inderpal Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356581384-23063-1-git-send-email-inderpal.singh@linaro.org \
--to=inderpal.singh@linaro.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox