From: Libo Chen <libo.chen@huawei.com>
To: Sonic.Zhang@analog.com, wsa@the-dreams.de
Cc: uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
lizefan@huawei.com, Libo Chen <libo.chen@huawei.com>
Subject: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful
Date: Thu, 9 May 2013 16:27:23 +0800 [thread overview]
Message-ID: <1368088044-20408-2-git-send-email-libo.chen@huawei.com> (raw)
In-Reply-To: <1368088044-20408-1-git-send-email-libo.chen@huawei.com>
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/i2c/busses/i2c-bfin-twi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index 05080c4..6617645 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
@@ -709,9 +709,9 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
out_error_add_adapter:
free_irq(iface->irq, iface);
out_error_req_irq:
-out_error_no_irq:
peripheral_free_list((unsigned short *)pdev->dev.platform_data);
out_error_pin_mux:
+out_error_no_irq:
iounmap(iface->regs_base);
out_error_ioremap:
out_error_get_res:
--
1.7.1
next prev parent reply other threads:[~2013-05-09 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 8:27 [PATCH v2 0/2] i2c: fix two wrong mem release Libo Chen
2013-05-09 8:27 ` Libo Chen [this message]
[not found] ` <1368088044-20408-2-git-send-email-libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-09 8:31 ` [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful Zhang, Sonic
2013-05-09 8:33 ` Zhang, Sonic
[not found] ` <B168F8A49F4BCF4C84FD23DA5F6363EEAD57-Nxh9ahLCS6GuVPpjEGsWsTcYPEmu4y7e@public.gmane.org>
2013-05-10 1:01 ` Libo Chen
2013-05-13 8:52 ` Zhang, Sonic
2013-05-09 8:34 ` Zhang, Sonic
2013-05-09 8:27 ` [PATCH v2 2/2] i2c: pxa: no need release_mem_region before request_mem_region successful Libo Chen
[not found] ` <1368088044-20408-1-git-send-email-libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-17 9:43 ` [PATCH v2 0/2] i2c: fix two wrong mem release Wolfram Sang
2013-05-19 2:13 ` Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368088044-20408-2-git-send-email-libo.chen@huawei.com \
--to=libo.chen@huawei.com \
--cc=Sonic.Zhang@analog.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).